Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210614154359.805555-1-benjamin.gaignard@collabora.com>
In-Reply-To: <20210614154359.805555-1-benjamin.gaignard@collabora.com>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Mon, 14 Jun 2021 12:33:33 -0400
Message-ID: <CAMdYzYq3ZYb-FA-SWmbgeUKk3gikNjz7Efc3rbLBxS9Erhb1yg@mail.gmail.com>
Subject: Re: [PATCH 0/4] Add USB2 support for rk3568
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc:     kishon@ti.com, Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        arm-mail-list <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Good Afternoon,

This was a hack just to get it to bind.
If you'll notice I've posted a second revision that works better, but
still is untested against anything other than the rk356x.
https://gitlab.com/pine64-org/quartz-bsp/linux-next/-/commit/51612157d7ae3f3c4267ed56676f5d1a952d698f

Very Respectfully,
Peter Geis

On Mon, Jun 14, 2021 at 11:44 AM Benjamin Gaignard
<benjamin.gaignard@collabora.com> wrote:
>
> The original pacth from Peter Geis is here:
> https://gitlab.com/pine64-org/quartz-bsp/linux-next/-/commit/cda136f853628259198d6f70c3e14c9e5c8e097f
>
> I have split the driver part of this patch in two:
>  - one to update reg usage
>  - one to add USB2 support for rk3568
> I have added patches for the bindings:
>  - some clean up
>  - add compatible for rk3568
>
> Benjamin
>
> Benjamin Gaignard (4):
>   dt-bindings: phy: rockchip: USB2: remove useless #phy-cells property
>   dt-bindings: phy: rockchip: USB2: Add compatible for rk3568
>   PHY: rockchip: USB2: Allow 64 bits reg property
>   phy: rockchip: USB2: Add support for rk3568
>
>  .../bindings/phy/phy-rockchip-inno-usb2.yaml  |  3 +-
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 85 +++++++++++++++++--
>  2 files changed, 78 insertions(+), 10 deletions(-)
>
> --
> 2.25.1
>