Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2959265pxj; Mon, 14 Jun 2021 11:01:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsFAw1E0VCovFLMwEy3EsE8FLFfYrFxsBpT/cCFxYHV0QATtXh9P8N7j4hvgZ12DRPT1Db X-Received: by 2002:a05:6402:35d1:: with SMTP id z17mr18716196edc.159.1623693717936; Mon, 14 Jun 2021 11:01:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623693717; cv=none; d=google.com; s=arc-20160816; b=DeUd8lnQbOkbojneQiJye52QBp/mhU9dun+Mzg7MU/AXyFsiGJg5FaJOsT7mXprQlB MEnuW7kmpL8QOdjCc1PW7LdCg4p4zt5n62qfx5K9BV3IOCDeIcW8f0MGRzjHO5OZ1Ij/ iOJbOlStk2s6k7YRAOXpv5Bav4CoEIN+OD3EO+V1f5MeZjk/TyJPkfBeen/55C4F/cpv 7dXJe4N3AdRhfg7k2wvEd2sflNAtSbZCSBKP1ec3ODEeh0Ir1DFuWkkRZ+19tMRz80Fe 400/XxqQpJhAII5n+1G9nuxnMRjxY8gqc+pCxEkfX8gSFWCpsByYEKCXZGmDt7OScjvy aIHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9eYVDaVHYr+Ta9Md8XT/8eZjugfQKObmCTnUfOcer/Y=; b=UB7cUpmGO7bi62x13eh7w0XNFU1VFt3/RwldINWoIIlrpValXLqWY9NXGYU7qCWmM2 WwApW5ROCxRrkLy1xYg2OV65pHcu20jCHneRcygFFrDvUzTcKxR3tuhO8y+Yqgg0HiWl mRl1cww5BJKqD7TtUQCAMK5FWfrfAgYAbUOr+gude6iQHePqXW/r0WUUNnUTzI7lD2ug vB7hiKMxHen5o6HTqq0eMWjypTy2CVTMNPyFpcrNm7k9pDUhm0vvGNdY8U0k+uayFeWZ odG1Ve+WKW17pyP1zwoBMLCGUJ89MOzdciRSZOgwaxYj4A1uu9DsStebrvSBjFr7krua ePkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GCtIlChO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si12251362ejd.638.2021.06.14.11.01.34; Mon, 14 Jun 2021 11:01:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GCtIlChO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234724AbhFNSBT (ORCPT + 99 others); Mon, 14 Jun 2021 14:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234637AbhFNSBQ (ORCPT ); Mon, 14 Jun 2021 14:01:16 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E3DAC0617AF for ; Mon, 14 Jun 2021 10:59:13 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id 69so6997432plc.5 for ; Mon, 14 Jun 2021 10:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9eYVDaVHYr+Ta9Md8XT/8eZjugfQKObmCTnUfOcer/Y=; b=GCtIlChOWoBbjJ/2yOkYALvlVjU+KxqrqCs0BWuqHB8ai1/8JsSvwpvekPJuHrofDo XdeZ8A+kK1NsP24zuk03cyQK4TuuShldjDlHH4iHMBHWbLuOjXbl1j4+8ybVAFU8orDB zipbuVybVQN2vloxTfXsa/tgbq/QtuQF8lOBYNmAbkpowIqHDmc4RPVhzfiDih64SmhH kdvOXNJZlwimPMf0noHqxZ0S5JunZuGmXDSCsjCwQw8xBLN8QsS5KUzJD5MwugO7UyPr /fODf8JjLECGf3DT6QZQZCCQn8dEJYS3c9AA4sfLAMcAfjUIK3GwALWUDLmmjp26dSKT l9sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9eYVDaVHYr+Ta9Md8XT/8eZjugfQKObmCTnUfOcer/Y=; b=kaWY725v5D8rdW7IjI8W9P8CtMGWRVVuckLCBfSygm0MfQK27QqTc8+f310zIbo9t1 CAmq4mOjP4CTlbJ5vc1SCxLB5rdrTKr2zbcTkmfAnXrciSDTs2o+PdqTPumEQRYsK40k KsJkCbTyxMmXYMUrs7y+w8OPjqbyBGRfs1Z0D2qWRjqMD/vfkFU6yrwGogwi3hKsbAZz J7C9zVjI2HIlJrDu7jjzehlgf1RybsrNkPgSRrLZNxTj7Ia7wCg93lHhGvJ9vtevRpEj 9btON/FeoAWgkpsLmCQtB6uh5HEyMJzxtxPlfZzbcYlH2rTxktHv1ULW4VbqeXkfzILz KI6A== X-Gm-Message-State: AOAM530zktUpnIwf7ktj2GJATnFjM2ul5QBsaTtddf5NTcxUQkIKEAzd V0JIXIJOUpqrz0CXWSXdYvTzwQ== X-Received: by 2002:a17:90a:8a0c:: with SMTP id w12mr351959pjn.130.1623693552674; Mon, 14 Jun 2021 10:59:12 -0700 (PDT) Received: from p14s.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id z17sm13553246pfq.218.2021.06.14.10.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 10:59:11 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] coresight: Propagate symlink failure Date: Mon, 14 Jun 2021 11:59:01 -0600 Message-Id: <20210614175901.532683-7-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210614175901.532683-1-mathieu.poirier@linaro.org> References: <20210614175901.532683-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeremy Linton If the symlink is unable to be created, the driver goes ahead and continues device creation. Instead lets propagate the failure, and fail the probe. Signed-off-by: Jeremy Linton Link: https://lore.kernel.org/r/20210526204042.2681700-1-jeremy.linton@arm.com Fixes: 8a7365c2d418 ("coresight: Expose device connections via sysfs") Cc: stable@vger.kernel.org Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 3cb8680c5828..1002605db8ba 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -1391,7 +1391,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev) } } - return 0; + return ret; } static int coresight_remove_match(struct device *dev, void *data) -- 2.25.1