Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Jun 2021 12:20:00 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jonathan Davies <jonathan.davies@nutanix.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Oliver Neukum <oneukum@suse.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrew@lunn.ch
Subject: Re: [PATCH] net: usbnet: allow overriding of default USB interface
 naming
Message-ID: <20210614122000.7cdef052@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <80b6e3ab-6b8f-abaa-9d20-859c89789add@nutanix.com>
References: <20210611152339.182710-1-jonathan.davies@nutanix.com>
        <YMRbt+or+QTlqqP9@kroah.com>
        <469dd530-ebd2-37a4-9c6a-9de86e7a38dc@nutanix.com>
        <YMckz2Yu8L3IQNX9@kroah.com>
        <a620bc87-5ee7-6132-6aa0-6b99e1052960@nutanix.com>
        <YMde1fN+qIBfCWpD@kroah.com>
        <80b6e3ab-6b8f-abaa-9d20-859c89789add@nutanix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 14 Jun 2021 15:53:53 +0100 Jonathan Davies wrote:
> >> Compare implementations of rename_netif in
> >> https://git.kernel.org/pub/scm/linux/hotplug/udev.git/tree/src/udev-event.c 
> >> (traditional udev, which handles collisions) and
> >> https://github.com/systemd/systemd/blob/main/src/udev/udev-event.c 
> >> (systemd-udevd, which does not handle collisions).  

That explains some user reports I've been seeing :o

> > Then submit a change to add the logic back.  This looks like a userspace
> > tool breaking existing setups, so please take it up with the developers
> > of that tool.  The kernel has not changed or "broken" anything here.  
> 
> (I didn't mean to imply that the kernel was to blame, merely that a 
> kernel change could help make things tidier.)

If you're attempting to fix this in systemd please share the PR info
so we can voice support!