Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 00:01:41 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        James Morse <james.morse@arm.com>, yazen.ghannam@amd.com,
        Robert Richter <rric@kernel.org>
Subject: Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA
 feature bit is not exposed
Message-ID: <YMfRxX/M4rJ5gM/R@zn.tnic>
References: <20210614212129.227698-1-Smita.KoralahalliChannabasappa@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210614212129.227698-1-Smita.KoralahalliChannabasappa@amd.com>
Precedence: bulk

On Mon, Jun 14, 2021 at 04:21:29PM -0500, Smita Koralahalli wrote:
> The SMCA feature bit is not exposed on the guest.
> 
> This causes a lot of noise in dmesg as the warning is printed for each
> logical CPU.
> 
> $ dmesg |grep -i family
> 
> [    0.031000] smpboot: CPU0: AMD EPYC-Milan Processor (family: 0x19, model: 0x1, stepping: 0x1)
> [    4.653422] Huh? What family is it: 0x19?!
> [    4.720732] Huh? What family is it: 0x19?!
> [    6.171028] Huh? What family is it: 0x19?!
> [    6.766552] Huh? What family is it: 0x19?!
> [    6.811119] Huh? What family is it: 0x19?!
> [    6.839855] Huh? What family is it: 0x19?!
> 
> Give these messages debug severity and output once as it is mostly useful
> for module developers and just noise for users.

I'm getting a patch like that on a pretty regular basis and each time I
tell people simply not to load the module in guests. Hypervisors do not
support SMCA...

But apparently those wrong error messages bug people on a regular basis
and I'm tired of typing this each time so I'll take a different version
of this patch: check X86_FEATURE_HYPERVISOR on entry in mce_amd_init()
and return -ENODEV if set.

So that this is done once and for all.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette