Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3131021pxj; Mon, 14 Jun 2021 15:22:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSbrjjfXEF+17XW4RoOZLBLfYKx6dMUk0KQsUJOji9yuSCufYnBWUjuiGr7RudXxanpDmU X-Received: by 2002:a17:906:724b:: with SMTP id n11mr17472180ejk.338.1623709347794; Mon, 14 Jun 2021 15:22:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623709347; cv=none; d=google.com; s=arc-20160816; b=Q82YkYAFOUlTerso+nflgdX3KgsvoRJittdjOhtSyFwNzUHg/LO9+dep2z8To67tZZ PHc9ZZkRopQ8C8cT6y/eLAms/zEojDLD3ksJRzJx3cacoRGFz09xj3lK52+uavchJy9z 2yo8iLSFcCNrbRCHMMMOPjSVL0WP2+p3n/lsT1CUGQCpis73Yyixr0gTYFLpBHrrQE+l 8xmoVp8cU1f6ZwOpsbKGDLlyoi1aLEpy9h7Bt4Q+0FlA2X9Y0d7ZIdt2kHsqvWH62Dph vq1ifwpDqAEerEccsy6A+51TeePwYCNy7t9bwGEEoFCAXgNzhMhJ9SeMGgnc5dKDU91Q 5HSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SD9ah05R7q3Xl2JjUIPjpWWyqe3h4fOAzvP8iSEX2Hk=; b=KQDM/XKxvLdoLrhQbK/7zkIZgXaIrGdiAMWbu+jK3c/2xZKMyAq0X1XApn8XvbZSzn J1clvT3wLv7LXnIqMvx+yC/cGtj/Din82s/EmSkP76bIUklWoFE8M8wfh50/PcAjjAQ9 k3LCGEzehEdylUAGMZXRMd9/cKeJSGxhUOpWyE/A074FrqQkwSlLPPU96GWKiiXFrc4z D+7Vy05PTGGz9WTYgeZSoIFH0PBnKWTB558laEcwCb+KWphlOcPwZZimZFcdaI99DbCR 5C1NE6G+gwZZIpqXgbxSWwBctIXAOYd74gerY4EDiY7T8iR5BXoerkaEBal2Unc2qZTS Dhbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=U5MJr1Vk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h7si12303468edr.267.2021.06.14.15.22.05; Mon, 14 Jun 2021 15:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=U5MJr1Vk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231598AbhFNWUQ (ORCPT + 99 others); Mon, 14 Jun 2021 18:20:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbhFNWUN (ORCPT ); Mon, 14 Jun 2021 18:20:13 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10002C061574 for ; Mon, 14 Jun 2021 15:18:09 -0700 (PDT) Received: from mwalle01.fritz.box (ip4d17858c.dynamic.kabel-deutschland.de [77.23.133.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id B1F9422253; Tue, 15 Jun 2021 00:18:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1623709086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SD9ah05R7q3Xl2JjUIPjpWWyqe3h4fOAzvP8iSEX2Hk=; b=U5MJr1VkoyQo1vU0kwB7yeUkXd4RKn9ihxT/uFlNjhcvsaeKUaKQOJRfUzZq4MRC1rtC9K 4/WWfmg1EKlDcpzjk0xc2OQteI1TSsFCbIDZ2/d0J2rIKVDuo1I0/UmzFZ+vqJg+9y9oW2 vNLQ0t/aBNfCsswPMXGlbJAQ5Ti5h3E= From: Michael Walle To: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter , Michael Walle Subject: [RFC PATCH 2/2] drm/etnaviv: add clock gating workaround for GC7000 r6202 Date: Tue, 15 Jun 2021 00:17:52 +0200 Message-Id: <20210614221752.1251-3-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210614221752.1251-1-michael@walle.cc> References: <20210614221752.1251-1-michael@walle.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The LS1028A SoC errata sheet mentions A-050121 "GPU hangs if clock gating for Rasterizer, Setup Engine and Texture Engine are enabled". The workaround is to disable the corresponding clock gatings. Signed-off-by: Michael Walle --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index 4102bcea3341..574e4e04dddc 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -613,6 +613,12 @@ static void etnaviv_gpu_enable_mlcg(struct etnaviv_gpu *gpu) etnaviv_is_model_rev(gpu, GC2000, 0x5108)) pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_TX; + /* Disable RS, SE, TE clock gating on affected core revisions. */ + if (etnaviv_is_model_rev(gpu, GC7000, 0x6202)) + pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_SE | + VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_RA | + VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_TX; + pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_RA_HZ; pmc |= VIVS_PM_MODULE_CONTROLS_DISABLE_MODULE_CLOCK_GATING_RA_EZ; -- 2.20.1