Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Punit Agrawal <punitagrawal@gmail.com>
To:     pmladek@suse.com, senozhatsky@chromium.org
Cc:     Punit Agrawal <punitagrawal@gmail.com>, rostedt@goodmis.org,
        john.ogness@linutronix.de, linux@rasmusvillemoes.dk,
        linux-kernel@vger.kernel.org
Subject: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition
Date:   Tue, 15 Jun 2021 08:56:35 +0900
Message-Id: <20210614235635.887365-1-punitagrawal@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
improving readability by removing vprintk indirection, inadvertently
placed the EXPORT_SYMBOL() for the newly renamed function at the end
of the file.

For reader sanity, and as is convention move the EXPORT_SYMBOL()
declaration just after the end of the function.

Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
--
Hi,

The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while
attempting to rebase the RT patches onto newer kernels.

Generally I avoid sending trivial changes on their own but this one is
a little hard to overlook. Also it felt like an obvious oversight in
the original patch.

Please consider merging.

Thanks,
Punit
---
 kernel/printk/printk_safe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c
index 7a1414622051..94232186fccb 100644
--- a/kernel/printk/printk_safe.c
+++ b/kernel/printk/printk_safe.c
@@ -391,6 +391,7 @@ asmlinkage int vprintk(const char *fmt, va_list args)
 	/* No obstacles. */
 	return vprintk_default(fmt, args);
 }
+EXPORT_SYMBOL(vprintk);
 
 void __init printk_safe_init(void)
 {
@@ -411,4 +412,3 @@ void __init printk_safe_init(void)
 	/* Flush pending messages that did not have scheduled IRQ works. */
 	printk_safe_flush();
 }
-EXPORT_SYMBOL(vprintk);
-- 
2.30.2