Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210614091530.22117-1-denghuilong@cdjrlc.com>
In-Reply-To: <20210614091530.22117-1-denghuilong@cdjrlc.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Mon, 14 Jun 2021 17:15:36 -0700
Message-ID: <CALvZod76wUmZ=EyaCeWKKAOaynpdWNMbcT_uz13LJJ4AunOV2Q@mail.gmail.com>
Subject: Re: [PATCH] mm: memcontrol: Remove trailing semicolon in macros
To:     Huilong Deng <denghuilong@cdjrlc.com>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Roman Gushchin <guro@fb.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

+lkml and linux-mm

On Mon, Jun 14, 2021 at 2:15 AM Huilong Deng <denghuilong@cdjrlc.com> wrote:
>
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>

Reviewed-by: Shakeel Butt <shakeelb@google.com>

> ---
>  include/linux/memcontrol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 3cc18c2176e7..1c1b11530ab6 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -192,7 +192,7 @@ enum memcg_kmem_state {
>  struct memcg_padding {
>         char x[0];
>  } ____cacheline_internodealigned_in_smp;
> -#define MEMCG_PADDING(name)      struct memcg_padding name;
> +#define MEMCG_PADDING(name)      struct memcg_padding name
>  #else
>  #define MEMCG_PADDING(name)
>  #endif
> --
> 2.31.1
>
>
>