Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     Fabio Estevam <festevam@gmail.com>
CC:     Vinod <vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Martin Fuzzey <martin.fuzzey@flowbird.group>,
        =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Dan Williams <dan.j.williams@intel.com>,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        Schrempf Frieder <frieder.schrempf@kontron.de>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Clark Wang <xiaoning.wang@nxp.com>,
        linux-spi <linux-spi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family
Thread-Topic: [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family
Thread-Index: AQHXK33LUkqD6t3KUUabL8+87acFPqsPOqgAgAV+imA=
Date:   Tue, 15 Jun 2021 01:55:29 +0000
Message-ID: <VE1PR04MB6688017E125D42C5DCB3C17D89309@VE1PR04MB6688.eurprd04.prod.outlook.com>
References: <1617809456-17693-1-git-send-email-yibin.gong@nxp.com>
 <CAOMZO5CNjpek0vkDrMyTmfbnr2cLcquck6QQBqXLBiyTDKPXvA@mail.gmail.com>
In-Reply-To: <CAOMZO5CNjpek0vkDrMyTmfbnr2cLcquck6QQBqXLBiyTDKPXvA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?8WWkhgBAK5O7QxiWgrMn4UIxSrUsBxlD2PvrdMWEKbUOMOCPf1m/YbYXcA?=
 =?iso-8859-1?Q?DV186jNrsqn23B/fvS1s6Sh+LDIA4UOZvDjoSCyUDzk/enLjcRmktroBW2?=
 =?iso-8859-1?Q?F3S5OHRWyrenMDbadjYp6uLPBeV4Em8ZROffi3G5MbtYdtUlC4Up0r664F?=
 =?iso-8859-1?Q?q6CnaOwxdE844ot46DKG5MDxNOxO427uF9eB/+CGblZR6YepXDNj8NugS9?=
 =?iso-8859-1?Q?uBpaWF6PqRyow8r/mioiC9XZ7FfLqgb8uj6lX+zAzgzLyoV3dXTqx9Z6bF?=
 =?iso-8859-1?Q?jGGFCl6UojkjKVaVIw1QeFWu+lDPSNBTx3NTgl1YJhyVjiRArU7Ib9RpR/?=
 =?iso-8859-1?Q?hn5JRXkqNZ8PFnw+H+STTgTGXcHCHkFhxzHGWQQ6gcRYNOxD4+2ppi829A?=
 =?iso-8859-1?Q?T6my9i7N6QXt9TUtSnWebXhyrbMm83apBf5R2kI99oYVwW9+njBssW6nVh?=
 =?iso-8859-1?Q?Z3UXvqTCsQZK8OrkvHuZ+OTpfjm4X1tHPB+F3xIXHBEixopF7WcZ0fuCxx?=
 =?iso-8859-1?Q?4lVsIofldwvR69bSLCG7UOUoNvLBTSmUGN8bD6tLAtpD25pyw6UTfEKN1n?=
 =?iso-8859-1?Q?fpKC98YkBVlAWz796pj7txDyPeuhP5dQbNdWPsbZbKo7ymyCw7ROBseNfd?=
 =?iso-8859-1?Q?CldJKXxnbo2o8YpXirJtZbrD3Yt45r8jWIAHr05t6P3Z6yVDWBmHDhOEA2?=
 =?iso-8859-1?Q?4Wt6eM9FSmwbzUhOPu5F6ZpIjVEcfW7BqwwZKf0ElK2StOOd5qoGFbeahB?=
 =?iso-8859-1?Q?u91p/Mt8p+8owRxkD/gs0TT4qtAUSTXLfTjpUOpt2ifmANdRUy945DPUVh?=
 =?iso-8859-1?Q?tLgAz9wkgUtU6W9BT7Y8ml1ftJZwwm842dI7mQ7zatOHTw7kKuQL4yr/Tl?=
 =?iso-8859-1?Q?pMlS1DeUU7AUKBEq9iGDVRB+eatYjvHjnR7vIOrik43k3J2FAZnCFb+yuQ?=
 =?iso-8859-1?Q?wdvFT3BwT/zTz3lNsJasfm04lSE8DAVWQZVIZkBM9x58kEEdBoORLGrC/A?=
 =?iso-8859-1?Q?dRujH7KDaCSvqKpvnybXznGZfL0gB+pyU1SFXqJiG8cSzwpJBsN4gpaDj+?=
 =?iso-8859-1?Q?FBbJm8ZU/6j0sGRyKjMiBOeMllg+FgFG/lL2rlOQlX4ArUEv3190h3t/Ta?=
 =?iso-8859-1?Q?idKWaPXWWUantvW88ENcwMIw9EvfnVoN2UaNIXxErW0ae9/ykIBHlhBG+W?=
 =?iso-8859-1?Q?BCwaEzsBZdBBxyNAjGdHZdHWdeqYN8QCZch50Tbd8vXnttWCLkQvvWbBtc?=
 =?iso-8859-1?Q?K1w9zAJHBqt1k5u91SJ5ShbtBslcU6DCDJQrmHlk26Px9HRe/LIs+apsw7?=
 =?iso-8859-1?Q?uuHuRMAZZXd5FIiazc9JjDO5RNxOMwfqvBIUiKBmmK3p/0U=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a18d0e51-5508-401b-e2da-08d92fa0a720
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2021 01:55:29.2710
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XQY9AWa6C7ZElcMF4NdeIu2rqXAPI5G5u1vqH8FjUiiY7v8RzmwCZVVVFPsTN0ds+DO4fj9VBWGXrJAaa5j5NA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7392
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/11/21 21:51 Fabio Estevam <festevam@gmail.com> wrote:=20
> Hi Robin,
>=20
> On Wed, Apr 7, 2021 at 4:15 AM Robin Gong <yibin.gong@nxp.com> wrote:
> >
> > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> > transfer to be send twice in DMA mode. Please get more information from=
:
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww=
.
> >
> nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&amp;data=3D04%7C01%7
> Cyibin.g
> >
> ong%40nxp.com%7Cab59d4a2e95a4351e48708d92cdffc09%7C686ea1d3bc2
> b4c6fa92
> >
> cd99c5c301635%7C0%7C1%7C637590162781662129%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6Mn0%3D%7C1000&amp;sdata=3DDIbrrAYvpoJ4lKrkDJYvyoixR9DcMCgVDwuW
> gI5fuVw%3D&amp;reserved=3D0. The workaround is adding new sdma ram
> script which works in XCH  mode as PIO inside sdma instead of SMC mode,
> meanwhile, 'TX_THRESHOLD' should be 0. The issue should be exist on all
> legacy i.mx6/7 soc family before i.mx6ul.
> > NXP fix this design issue from i.mx6ul, so newer chips including
> > i.mx6ul/ 6ull/6sll do not need this workaroud anymore. All other
> > i.mx6/7/8 chips still need this workaroud. This patch set add new
> 'fsl,imx6ul-ecspi'
> > for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need
> > errata or not.
> > The first two reverted patches should be the same issue, though, it
> > seems 'fixed' by changing to other shp script. Hope Sean or Sascha
> > could have the chance to test this patch set if could fix their issues.
> > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> > on i.mx8mm because the event id is zero.
> >
> > PS:
> >    Please get sdma firmware from below linux-firmware and copy it to
> > your local rootfs /lib/firmware/imx/sdma.
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit=
.
> >
> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux-fir
> mw
> >
> are.git%2Ftree%2Fimx%2Fsdma&amp;data=3D04%7C01%7Cyibin.gong%40nxp.c
> om%7C
> >
> ab59d4a2e95a4351e48708d92cdffc09%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C
> >
> 0%7C1%7C637590162781662129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDA
> >
> iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DuL
> %2F
> >
> 6w%2F7JF76dqTfKYk4BT%2F5flWr0d3U2O86ABSq2UhI%3D&amp;reserved=3D0
>=20
> Without this series, SPI DMA does not work on i.MX8MM:
>=20
>  [   41.315984] spi_master spi1: I/O Error in DMA RX
>=20
> I applied your series and SPI DMA works now:
>=20
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks Fabio.
Hello Vinod, Mark,=20
Is my patch set good enough to merge? I remember someone else are
requesting it from last year like Fabio.=20