Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] tracing: Remove set but not used variable 'ret'
To:     <rostedt@goodmis.org>, <mingo@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <weiyongjun1@huawei.com>, <yuehaibing@huawei.com>,
        <yangjihong1@huawei.com>, <yukuai3@huawei.com>
References: <20210527091032.3878436-1-libaokun1@huawei.com>
From:   "libaokun (A)" <libaokun1@huawei.com>
Message-ID: <4ab45eeb-ad26-03e8-f2c5-2dc4582a2946@huawei.com>
Date:   Tue, 15 Jun 2021 09:59:10 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210527091032.3878436-1-libaokun1@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

ping

在 2021/5/27 17:10, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> kernel/trace/trace_events_hist.c: In function 'unregister_field_var_hists':
> kernel/trace/trace_events_hist.c:5228:6: warning:
>   variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>   kernel/trace/trace_events_hist.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index c1abd63f1d6c..af4da32f7eab 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -5225,13 +5225,12 @@ static void unregister_field_var_hists(struct hist_trigger_data *hist_data)
>   	struct trace_event_file *file;
>   	unsigned int i;
>   	char *cmd;
> -	int ret;
>   
>   	for (i = 0; i < hist_data->n_field_var_hists; i++) {
>   		file = hist_data->field_var_hists[i]->hist_data->event_file;
>   		cmd = hist_data->field_var_hists[i]->cmd;
> -		ret = event_hist_trigger_func(&trigger_hist_cmd, file,
> -					      "!hist", "hist", cmd);
> +		event_hist_trigger_func(&trigger_hist_cmd, file,
> +					"!hist", "hist", cmd);
>   	}
>   }
>