Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3279190pxj; Mon, 14 Jun 2021 19:47:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqW2FFaGZbQmC1mt6w+2CZFDMbCek2PLeYs2x1EwarwpD3/2jehxIAXDe5X98Jl214JRis X-Received: by 2002:a17:907:1b1b:: with SMTP id mp27mr17771752ejc.538.1623725270754; Mon, 14 Jun 2021 19:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623725270; cv=none; d=google.com; s=arc-20160816; b=ySv1MQLxMBKBH3wGiX1Fn5mFNO16yRI3QCWzQJt1DVHISCUYLAQNFr5n0BSc5cxytY 329G6bB415z9C5Yz23cH86oMjytSYm5xvt4rApJ6YVqIv3iZvxoImsysd4C9sCuRGEz3 qTarhLrjPqSAsuPHyNtKMvKjTUelm/9txFTDha+gU1v0+IK8U5FP2jxKpzroF4oHYVIO O7G8bUKzAgFNM5vn9eeqg2Bzb6cfvdJZ/uVXLu10WMzWeghn4v3iYoO9LhbImMP/wriy 9Q7yopWYMBOCiy3SqQ87DrKk/bmgkwHrn35e6687QV6KF2HM5Gnsbp2Co6qc9GNPIOY7 oqng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=vVu/q50mLKZC8+FmqE6RzI+X9/hmuWYOAB854u4sNe0=; b=gbGM+7qC/O4MCJAM2+Qvhu12i1UotxpH+Po7oNLctTu3ouQvX1F1G8CfM69cYIBq8e WriMpnkEFnRqDTNjKrbTsn87YUttAMEnub8WFWjt/d54Ev/rAMukN9LT5/kByA/bUDhP uAelcpFtITLyN5cnQg928Q0JQI9ohii7O9hGUEwUcQAVv5gROTAdC+Z96ZKNphsL6M9g 0ZgjzBCgWrybpqzSlKgkK1fqoe9lyZlSo/mdiqqDuwggFmEnashslFTJVN9zkmwXtylm NZeAmYzmfR20Cg10ApTdyo6Bfxu3gHhUAB/7ocHHH/S4iud5nHz29G2FB9x9NANbTARN S0dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lH8grbcF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j15si13026015edq.337.2021.06.14.19.47.27; Mon, 14 Jun 2021 19:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lH8grbcF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbhFOCsa (ORCPT + 99 others); Mon, 14 Jun 2021 22:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbhFOCs3 (ORCPT ); Mon, 14 Jun 2021 22:48:29 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2892C061574 for ; Mon, 14 Jun 2021 19:46:24 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id gt18so1377291ejc.11 for ; Mon, 14 Jun 2021 19:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vVu/q50mLKZC8+FmqE6RzI+X9/hmuWYOAB854u4sNe0=; b=lH8grbcFhCAO4tnhWvsAdMiBjS0dTx3HutQQBO9coicIiuYTgrOeRLwpRjHXqMce1/ jlap8x9hVMfojCAQL0TmYXz+FyLqz+bqKIlRSJS3e+s2DHZplVtmv0r7hBkVZzC2o+er nxlHTtAb3r4mchIxkgI5MOGYLAzko3i2pecmOL0Z42EF0b3ox+/Pmr1dSd7003L0FrDr aoAuPuvRiIIuj+kiBzu5zJQcJDus9CmYTMuIB9AyBdYK4OnA7adx7M6L4FlbGfyhjdmq I8QALrFxn/N9hR0DJ6Xv8/n4+4+0/0zRI6bM7liU6yRbMP0oPJL0Pt48DtbAVjrqTH/u BxVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vVu/q50mLKZC8+FmqE6RzI+X9/hmuWYOAB854u4sNe0=; b=MWlssjUwyrX1417TslAeDnVWZXx2AkPHF0fgcjBx9x4FEHwY6EjfMJzDGU9cWme/+R k7RoXE8Zahj9YkwuMjZ9ono+1M0iafmG6R7+Sjc4nJez7q+Tif7KulkcT13oSV87bTDF vZRbtq1JaEyIFuyOV+sKuiN5zT7EfG6v68Ou7IoRagKiB7yXhUwpV80vVBNVGujMlZu8 aCrB255pqCw/wCbOqbucoiM7o+fEdx05ZCiiHK9qQSdLqQBsOJLkQAKBTFV7jSaJ62AA 8MxVroZJTWrxWwWgvLps7Rv+eQFHjBolHA3BC30MkOHXCr005nA1qMtRsgbceuw0R71k 5REA== X-Gm-Message-State: AOAM533MZRRdIEE6mRMwY0PEftv/AlekNfPQMGjQRwpMJYIFHdFEWJyE mAgiEmqTxfVGw5+7lkOI/vRQE0d/CF4EpuVV9YZ3NYojMlx0gQ== X-Received: by 2002:a05:6512:1144:: with SMTP id m4mr14563109lfg.390.1623724714373; Mon, 14 Jun 2021 19:38:34 -0700 (PDT) MIME-Version: 1.0 References: <20210615012014.1100672-1-jannh@google.com> <20210614190032.09d8b7ac530c8b14ace44b82@linux-foundation.org> In-Reply-To: From: Jann Horn Date: Tue, 15 Jun 2021 04:38:08 +0200 Message-ID: Subject: Re: [PATCH v2] mm/gup: fix try_grab_compound_head() race with split_huge_page() To: Andrew Morton Cc: Linux-MM , kernel list , Matthew Wilcox , "Kirill A . Shutemov" , John Hubbard , Jan Kara , stable , Michal Hocko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 4:36 AM Jann Horn wrote: > If you don't like the ifdeffery in this patch, can you please merge > the v1 patch? It's not like I was adding a new BUG_ON(), I was just > refactoring an existing BUG_ON() into a helper function, so I wasn't > making things worse; and I don't want to think about how to best > design WARN/BUG macros for the VM subsystem in order to land this > bugfix. Ah, nevermind, I hadn't seen that you already merged this one.