Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] drm/hyperv: Remove unused variable
To:     Thomas Zimmermann <tzimmermann@suse.de>, <drawat.floss@gmail.com>,
        <airlied@linux.ie>, <daniel@ffwll.ch>
CC:     <zhangjinhao2@huawei.com>, <linux-hyperv@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
References: <20210609024940.34933-1-pulehui@huawei.com>
 <078d9bb5-e7af-4961-f4c1-cd3ab415cff4@suse.de>
From:   Pu Lehui <pulehui@huawei.com>
Message-ID: <fb6bacb5-719f-39f3-fe72-b5595dbb99e4@huawei.com>
Date:   Tue, 15 Jun 2021 10:04:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <078d9bb5-e7af-4961-f4c1-cd3ab415cff4@suse.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2021/6/9 15:46, Thomas Zimmermann wrote:
> Hi
> 
> Am 09.06.21 um 04:49 schrieb Pu Lehui:
>> Fixes gcc '-Wunused-const-variable' warning:
>>    drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning:
>>      'hyperv_modifiers' defined but not used [-Wunused-const-variable=]
>>
>> Signed-off-by: Pu Lehui <pulehui@huawei.com>
>> ---
>>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c 
>> b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>> index 02718e3e859e..3f83493909e6 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
>> @@ -149,11 +149,6 @@ static const uint32_t hyperv_formats[] = {
>>       DRM_FORMAT_XRGB8888,
>>   };
>> -static const uint64_t hyperv_modifiers[] = {
>> -    DRM_FORMAT_MOD_LINEAR,
>> -    DRM_FORMAT_MOD_INVALID
>> -};
> 
> This constant should rather be used in the call to 
> drm_simple_display_pipe_init(). [1]
> 
> Best regards
> Thomas
> 
> [1] 
> https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c#n161 
> 
> 
> 
>> -
>>   static inline int hyperv_pipe_init(struct hyperv_drm_device *hv)
>>   {
>>       int ret;
>>
> 
Hi Thomas,

Thanks for your suggestion, I will fix it in v2.

Best regards
Lehui