Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3348994pxj; Mon, 14 Jun 2021 21:56:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQqQ+qFJiRrSKxHfUloYzzYkWJ1QjIZ4FW2f7W/qnk0WgLGqHBGHHzdV3pGSSthSM84vF4 X-Received: by 2002:aa7:c3d0:: with SMTP id l16mr20926846edr.65.1623732964286; Mon, 14 Jun 2021 21:56:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623732964; cv=none; d=google.com; s=arc-20160816; b=DEe7zCy8MA98be10ccHY7HA7oEnGR42z/TNYE7knhoxgOBMh51HU/kVBb75SWNHr1D tfuBGfxkHDxUuo+axyXn9brLERfUVKvo2VkNiUq4sC2Ancg9Tez7fadLgT576+noru2u m8QmTGO2TmE+9G2Vzh0Lgjcivt1s2QVCOmGnfdB35rktaczSjkqYGDRX9aTT0mtJWeYZ 5JFvMpruh6zJvnHf/Xrbo/ljWA4ANvLBDLFaWHNNneZiz2kyKwIxSNuUksUohlZ8fxx+ KkDDSPO6NEHPOvf3e/2PsjY1D8oVXLnmqdm+ty/66f6qpZEtmivhW/67fEIBjJqLeW/w FK7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fJYii850KTFtEGxTHO59JWrZIaXAVHaRTNmPAb8kLfA=; b=vqT4mjl8xSaM2bP4PWwVy6Ps7Cjp09QOOExEHamKXtQquobgkzZQeGQj58n5NjqVnf GZ5d4sfZVdCk+A3V/n33hzi7VrvrJzpDXoNrfSoiULYC3Rn/abP4hosY7SHaTIkSrmK5 VkfKvKWlz0EvIC5IslQu7KqIudwDTS41AodKzmR3pSWnP6cYntKZ73+kAY92tqGoyYTT IXVqNK1kqtnCTmqGGPgIcZoK7GRx218bxl0m6anXfYR0Aiv4PVm1RDxZJWT9dD3AEWYR FksJgP/MGICLURFbIKyuoR5tYhNsbYrINhhem5ImeL2lGOLqGShcoyDYBABLuHR22h8/ Vfow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c5luMNlX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m27si1655591ejl.597.2021.06.14.21.55.39; Mon, 14 Jun 2021 21:56:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c5luMNlX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbhFOE4V (ORCPT + 99 others); Tue, 15 Jun 2021 00:56:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:48028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhFOE4U (ORCPT ); Tue, 15 Jun 2021 00:56:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F8736140C; Tue, 15 Jun 2021 04:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732855; bh=Hy47A6sDeDK5g7Q5O8jSY970MU9+ZwCkDct4y1d2MOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c5luMNlXN45gsnjoT7ZAEHeSo4zvFcWP9bbHYPHa2DXxgXuwPtyM+U/2Oawme604d QCsuyDD/R9ZHrHa66qMInzV4pFn0ia7wc2Q5fOejGauo5+FoDRWgONUTfJWFmi4Bhr FB5C3UysQ1jKKZABMCKKcgh4gkX2frG+MQkR/tdM= Date: Tue, 15 Jun 2021 06:54:12 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/4] remoteproc: core: Move validate before device add Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-3-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623723671-5517-3-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 07:21:09PM -0700, Siddharth Gupta wrote: > We can validate whether the remoteproc is correctly setup before > making the cdev_add and device_add calls. This saves us the > trouble of cleaning up later on. > > Signed-off-by: Siddharth Gupta > Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/remoteproc_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.