Date: Wed, 8 Nov 2006 11:30:23 +0100
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: David Brownell <david-b@pacbell.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, andrew@sanpeople.com
Subject: Re: [-mm patch 1/4] GPIO framework for AVR32
Message-ID: <20061108113023.0281c0f6@cad-250-152.norway.atmel.com>
In-Reply-To: <20061107213604.692421DC800@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
References: <20061107122507.6f1c6e81@cad-250-152.norway.atmel.com>
	<20061107122715.3022da2f@cad-250-152.norway.atmel.com>
	<20061107213604.692421DC800@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1004
Lines: 26

On Tue, 07 Nov 2006 13:36:04 -0800
David Brownell <david-b@pacbell.net> wrote:

> > +#define EXTERNAL_IRQ_BASE	NR_INTERNAL_IRQS
> > +#define NR_EXTERNAL_IRQS	32
> > +#define GPIO_IRQ_BASE		(EXTERNAL_IRQ_BASE +
> > NR_EXTERNAL_IRQS) +#define NR_GPIO_IRQS		(4 * 32)
> > +
> > +#define NR_IRQS			(GPIO_IRQ_BASE +
> > NR_GPIO_IRQS)
> 
> Did I miss something, or are the IRQs starting at GPIO_IRQ_BASE
> not actually implemented?  There's no irq_chip with name "GPIO"
> or anything.  The AT91 code should be almost a drop-in there...

No, you didn't miss anything, but I do want to implement a "GPIO"
irq_chip like at91 does. I suppose I can reduce NR_IRQS a bit until
it happens, but then again it's perhaps better to just implement the
irq_chip thing...

Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/