Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3349040pxj; Mon, 14 Jun 2021 21:56:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjemglYCeBsD5ouTU0fOWUHWbQdwCDFCIkiGFczvEUxKgrgGggeJP/3N3zlsUd66g+7bOI X-Received: by 2002:a17:906:4111:: with SMTP id j17mr18588068ejk.488.1623732969391; Mon, 14 Jun 2021 21:56:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623732969; cv=none; d=google.com; s=arc-20160816; b=KlXV3h3CrUR2K6+I2+wPenk1+8TVEPrkl3yEe3mv0oaFlJzApsu0KrzYVeb9M/xSFR 6IpGQLqr/TBc61E/rzGrG8mCBpWb8/vWFu/YfBFuMFTOUORBXMastcQcM3Z0Gixrt1ck DZpGosviGL63N34IhgveTD0snstm6fEUHE+lDXmH3aBT9G7yckg3Y1A61usEfzZvwHZn guVvhSBXzPgQImaMyX4EcFGSDt1hVSu8/0xLY0VNJXvL4r8kkQb6+Q3GEY8Q+mrqqFVt EZapx5mB4B7y8bTZX/R2rSbX7b4TaQdsEKphLtWQQbluhRBxgvv+Ham/5G8FlfKkgahT vzxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gsoK29CpHQLA/GfD4R0SbpKiCQ+DkUxbidUbSWuX6DE=; b=HXGttfj/8TWQFNkJ2m/y8f/04QJP35+2TK1+/dY6p5SAW6GwIzDPHSU0PCoESimB/S KA+1uG6+RcpmNUTJkhuPOmVnO4KT1/ePgDQMQY7OQ0/2s3w0q4u+arOX/ttYkYp/Vtad FoFqWOwvt0ZH2wVieqnlKKTvzI5cMOa8f2Ld+s/+7JDEi0Lbj6csdNvWnqNm8JtzJB+V uGKtQiRhkFCKpb1BMWQw9AXbRpTHTlJjzXcRWXjp89qAZ3KxFjF6sI6A3kUxTuf/vWxG TMeZbnfZHF0VetS7SUZows3rxjQYt9hNudEFDB12j/amaDFhDlTvIW9r32NfFKZmcYwA g97g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mMFrdbhv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka11si14354980ejc.367.2021.06.14.21.55.47; Mon, 14 Jun 2021 21:56:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mMFrdbhv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbhFOE4b (ORCPT + 99 others); Tue, 15 Jun 2021 00:56:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhFOE4a (ORCPT ); Tue, 15 Jun 2021 00:56:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C9608613DA; Tue, 15 Jun 2021 04:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732866; bh=/MfjuVHcyNn6fWowwYthRN2342Yc3ZUOxofEdm2nQBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mMFrdbhvWXdpjLcxuF3xf6vpkmJXjrIG3jyesSwW0e7ng00LGZCzzBO7njw6I6VRI x1TVfe/rVZpdnYYsgO24AZwso/Pai1tDN0J4ujKKm1l/N5eummTxlpGaYlJ2KV42g/ vJb7hlfVt2fJWFpvqAAvDAuUp8KiYA4N69bZBWI4= Date: Tue, 15 Jun 2021 06:54:23 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 3/4] remoteproc: core: Fix cdev remove and rproc del Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-4-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623723671-5517-4-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 07:21:10PM -0700, Siddharth Gupta wrote: > The rproc_char_device_remove() call currently unmaps the cdev > region instead of simply deleting the cdev that was added as a > part of the rproc_char_device_add() call. This change fixes that > behaviour, and also fixes the order in which device_del() and > cdev_del() need to be called. > > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_cdev.c | 2 +- > drivers/remoteproc/remoteproc_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.