Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3349215pxj; Mon, 14 Jun 2021 21:56:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHmvyxORdiW3GxwsZ8LjqOcd/9syVuV63glOqA4W/9XvWaxjHGq/aCReNounLEkA5OYW9W X-Received: by 2002:a17:906:2b85:: with SMTP id m5mr19078052ejg.141.1623732990766; Mon, 14 Jun 2021 21:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623732990; cv=none; d=google.com; s=arc-20160816; b=V4WRR1HCdpQUxGWUJT3Uz7VwSXyKzJjtYDn+//i0QZKnjqCLG4qOUKgX6AGhcl66LB 5nEVKaLnSTv6APxb770aW2TC74wFINcDeR5HWwfqsNIzVkAYfH1KRbEs6uCzA66/oAXQ dRd5590wu8kd4cLY0UIAUEAVsYwLjeu/lwn8v+b68kghm42wwJApGITlC+GrzDWys4Et PtI/OngrpxevhzL3PTUXLzYq5+ui34cdTUfz+krF9llvE/2h6+BV6VNtSapiWtSHy3Qh qQz+Ep49xetTiziFb6gJQZDqYgeMFft/mqCDLmb9QpN+8+LnVJwn0jWrxLg5eBe3xl6z 1xtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jyitj0+zV5WdH/BytNjtp9ybCIUa4wlXrPD9vBCS20o=; b=zaIsco+6IFFWkyp2EBq+3Ov5gST8833O6h5bqq3TFYVVhZ3RILpC4RZg5oegJeGdPD mUACDAg3F28FMmVJf9YN/ZX7TE4qnFSxBQBeQZVQPv8J0AF//rymGhToavCp9ujoRmZf 8++AxxvlFNZ3s8DuZRkbbwafe2uYXlCopYXIbtK2FNOv1WFJt6+YMXoQlFSkImJKArCf kXsPD+sWG949BJ7qgIdR9g/a4myyDawzum5Hp8ofixrv/J1lupO3Sf4TAEbktQH/10zP fYDBACViFRiQBYsSwa04Bv0MFs+C2FB9jWjAnArX0Tn5qLc/N0naQWK3MHtyw7I416iW +nvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yg5nwCP1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s6si3312969ejs.573.2021.06.14.21.56.08; Mon, 14 Jun 2021 21:56:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yg5nwCP1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbhFOE4j (ORCPT + 99 others); Tue, 15 Jun 2021 00:56:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:48204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhFOE4j (ORCPT ); Tue, 15 Jun 2021 00:56:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 867FA6140C; Tue, 15 Jun 2021 04:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732875; bh=LOUrrre8qSZUzINtpnJMg/SuDS2uZEyc8OgjEuONmRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yg5nwCP1U+2AIZi5180GqrGZxiQygtRJ39hiJbUDPGyvmygZw69Zg2trAbzxvJaVI ohi7+dGvIkj5Nwnnw0dBeDuwbp7phAthXlHvR/qHf6xNyiO4/mVRD5BfJD4cq0wOye d6V8wqcKpNDTZ+xeL/WoWA3a/tKE50UA06NbrVt0= Date: Tue, 15 Jun 2021 06:54:32 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 4/4] remoteproc: core: Cleanup device in case of failure Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-5-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623723671-5517-5-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 07:21:11PM -0700, Siddharth Gupta wrote: > When a failure occurs in rproc_add() it returns an error, but does > not cleanup after itself. This change adds the failure path in such > cases. > > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.