Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210609115916.2186872-1-chengzhihao1@huawei.com> <7883956d-4042-5f6b-e7dd-de135062a2ef@isovalent.com>
In-Reply-To: <7883956d-4042-5f6b-e7dd-de135062a2ef@isovalent.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 14 Jun 2021 23:23:12 -0700
Message-ID: <CAEf4BzYE=kRDz4e+8MEe6Pget-C4XKg8bwAgEHYf+KujUtFJeQ@mail.gmail.com>
Subject: Re: [PATCH] tools/bpftool: Fix error return code in do_batch()
To:     Quentin Monnet <quentin@isovalent.com>
Cc:     Zhihao Cheng <chengzhihao1@huawei.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 9, 2021 at 6:34 AM Quentin Monnet <quentin@isovalent.com> wrote:
>
> 2021-06-09 19:59 UTC+0800 ~ Zhihao Cheng <chengzhihao1@huawei.com>
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 668da745af3c2 ("tools: bpftool: add support for quotations ...")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> Reviewed-by: Quentin Monnet <quentin@isovalent.com>
>
> Thank you for the fix.

This has been applied to bpf-next last Friday. Patchbot missed it.

> Quentin