Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition
To:     Punit Agrawal <punitagrawal@gmail.com>, pmladek@suse.com,
        senozhatsky@chromium.org
Cc:     rostedt@goodmis.org, john.ogness@linutronix.de,
        linux-kernel@vger.kernel.org
References: <20210614235635.887365-1-punitagrawal@gmail.com>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
Message-ID: <8c16059d-6e58-a3e4-25ef-7e2bcabecd86@rasmusvillemoes.dk>
Date:   Tue, 15 Jun 2021 08:50:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210614235635.887365-1-punitagrawal@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/06/2021 01.56, Punit Agrawal wrote:
> Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
> improving readability by removing vprintk indirection, inadvertently
> placed the EXPORT_SYMBOL() for the newly renamed function at the end
> of the file.
> 
> For reader sanity, and as is convention move the EXPORT_SYMBOL()
> declaration just after the end of the function.
> 
> Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
> Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
> --
> Hi,
> 
> The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while
> attempting to rebase the RT patches onto newer kernels.
> 
> Generally I avoid sending trivial changes on their own but this one is
> a little hard to overlook. Also it felt like an obvious oversight in
> the original patch.

Yes, indeed, sorry about that, and thanks for fixing it.

> Please consider merging.

Petr, as this is causing trouble for the -rt patchset, please consider
if this could make it to Linus before v5.13 release.

Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Rasmus