Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To:     <rostedt@goodmis.org>
CC:     <ardb@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-next@vger.kernel.org>, <mark-pk.tsai@mediatek.com>,
        <peterz@infradead.org>, <sfr@canb.auug.org.au>,
        <yj.chiang@mediatek.com>
Subject: Re: linux-next: build failure after merge of the ftrace tree
Date:   Tue, 15 Jun 2021 14:51:40 +0800
Message-ID: <20210615065140.22032-1-mark-pk.tsai@mediatek.com>
In-Reply-To: <20210610110638.7e84912d@oasis.local.home>
References: <20210610110638.7e84912d@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

> 
> On Thu, 10 Jun 2021 10:26:39 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Thu, Jun 10, 2021 at 06:08:25PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the ftrace tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > Cannot find symbol for section 255: .text.opal_int_set_mfrr.
> > > arch/powerpc/platforms/powernv/opal-call.o: failed
> > > 
> > > and many more similar.
> > > 
> > > Caused by commit
> > > 
> > >   9e419de4c678 ("recordmcount: Correct st_shndx handling")  
> > 
> > Argh.. lemme try and reproduce :/
> 
> I'll go and revert this patch, and wait for a new version from Peter.
> 
> Hmm, crap, this is also sent to Linus. I'll stop that too.
> 
> -- Steve

I found the the build fail is because PPC64 is big endian and this
patch use st_shndx directyly.

Here is the case which cause this problem:
recordmcount search symbol for txtndx = 255(0xff), but the
corresponding symbol has st_shndx = 0xff00(bit endian) which
equals SHN_LORESERVE, so the updated get_symindex() return 0.

I send the patch v2 to fix it.
https://lore.kernel.org/lkml/20210615064720.21950-1-mark-pk.tsai@mediatek.com/

Below is the test environment I used:
https://musl.cc/powerpc64-linux-musl-cross.tgz
make allyesconfig CROSS_COMPILE=powerpc64-linux-musl- ARCH=powerpc
make vmlinux CROSS_COMPILE=powerpc64-linux-musl- ARCH=powerpc