Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   Justin He <Justin.He@arm.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>
CC:     "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Eric Biggers <ebiggers@google.com>,
        "Ahmed S. Darwish" <a.darwish@linutronix.de>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH RFCv3 3/3] lib/test_printf: add test cases for '%pD'
Thread-Topic: [PATCH RFCv3 3/3] lib/test_printf: add test cases for '%pD'
Thread-Index: AQHXXtr4yj2ZFiynnEqJXnMpAugWBKsPVv2AgAVSIdA=
Date:   Tue, 15 Jun 2021 07:06:03 +0000
Message-ID: <AM6PR08MB4376C7D2EEAF19F4CA636369F7309@AM6PR08MB4376.eurprd08.prod.outlook.com>
References: <20210611155953.3010-1-justin.he@arm.com>
 <20210611155953.3010-4-justin.he@arm.com>
 <4fe3621f-f4a0-2a74-e831-dad9e046f392@rasmusvillemoes.dk>
In-Reply-To: <4fe3621f-f4a0-2a74-e831-dad9e046f392@rasmusvillemoes.dk>
Accept-Language: en-US, zh-CN
Content-Language: en-US
Authentication-Results-Original: rasmusvillemoes.dk; dkim=none (message not
 signed) header.d=none;rasmusvillemoes.dk; dmarc=none action=none
 header.from=arm.com;
nodisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: 03Ku4CwA7tLzwxU5Sf7NLkDUqb+ZByoZQV9WL23BPNAobs2v17+Kj05uVPVGBmeDk2ZarFaAB+F4v2G84lykQTsR1F0lASHVMSd075QIENm/zBft6ebRJ2cZrnyuAKxAzZDa/Zg/PckmqxQJ9+3WQy4+1zJfoIX28iLq36/Cxethx7wcoGWdFEbTU4aS6JwQSGjmEmJcHm97iYnyuIrtykrOFCE+Yz+m+NLX3NpWuZYuE6y/QCQgvJdaff20f/+TuhslQ6drdHR6nC1nXQSqrZ95Hxhiy4ZubXie9eA8x73pJxGzlEPLA+YY6T5DqsXLESDnblzNNzmgNiBtHg7jV/IUUD4kiUDIZMuHu99vMyLwZhMpb+vX8bTuKeiJ9BYbbEKGH2HVeeA9AWXWMht4JeZjzy+F899WRimaZS3PhIbK4r44dRo5ssFMz2AyUkzavtpcY4V2FB7+hl51SY1XrpgwAmL1qHJWM6l50YAwb8LcATR8glukIZW9tU4YOeA63ApDyE6L45z1Fj4tERCjwJgo1X+xSJQQ5TqZIOdfu2kjRMJLhrf9mTp5co2M0UZmK24pxsSb/+sdyXutegf1t3ptnAtJF+FMc2lEWieNm0c=
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB4376.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(396003)(376002)(39850400004)(7416002)(76116006)(6506007)(86362001)(66946007)(9686003)(110136005)(53546011)(316002)(55016002)(8936002)(186003)(52536014)(33656002)(54906003)(5660300002)(64756008)(71200400001)(66446008)(83380400001)(478600001)(122000001)(4326008)(2906002)(66476007)(8676002)(26005)(66556008)(38100700002)(7696005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B+DUxT/FvSnR1ARuDuVLIkwAHJ4NgHQtlmhKBfPMblTqD4Jb9k5RybjhbnRI?=
 =?us-ascii?Q?LHLXZAP55JwdT43HbPmBPwWyBZ6qLJXhlhVNT1AU6xJGA7LrvnIcdckDeTGX?=
 =?us-ascii?Q?+Xg8IakPNLJ2g4vQRRctBZ0J2EK3S7vVSgEQXaop5IbbSBe3uamc1NBrrNVL?=
 =?us-ascii?Q?KadY+YR7hMTmfpgxK0ndC21euRXp8oq8Zg2z4mJ4XZkOXwuTMcqA+OHeD02y?=
 =?us-ascii?Q?Uu0Z4mX7ziZsxR66UPchUhbVDGRMdlItTBSy2WskYpuNwl0r1tMY3ZzM6t26?=
 =?us-ascii?Q?NqX2KgUUaFOI8wMf0YB97wZTxWtyeV364EAlwsMU8pnhQH0HZD3EMNkTkwR3?=
 =?us-ascii?Q?rj1Q5ESFbAucWvPyahRiSbl5cXh1M+CfROqFyslxHMb1DCX7txqS/2W2wYnU?=
 =?us-ascii?Q?8hKDCQbu4wJWuTjCIOjbhUdt4F/Gc+viTt2/dgCy+sdJXedzWenx/6zC32sQ?=
 =?us-ascii?Q?aZjMXOQ9lqdvG2W1mGcpn4O/vnWgC4W3O7QJB0LkTJTC0FWMI2UsOzPHk2TS?=
 =?us-ascii?Q?QeAxsEf0s1sRYjcIwTouGgzKkD8U0ByEH9hSNsxME48XsjmDu1bL5nWmm4xN?=
 =?us-ascii?Q?m/6qqDI0CDYKGYB1L4blZzuXgwZ3d9hrQSU0DmXX3yBLiR4cj1lCzCZycQ0G?=
 =?us-ascii?Q?9kdOa5xM/2kYYFICl1RsQjnj0/sjlOclayrmfna88pcmb/H7Rf3iyBFl8SQ1?=
 =?us-ascii?Q?FNpWHD/HGrZnGe8hBnCBfksIfrY3tocCo5Dlhcoxi3tzadlNcXmHdMDLyYLn?=
 =?us-ascii?Q?7KLWJWBA/qpBaVHUut5S+JHX1oXRIe6ELo+cpiEY42TLVL+I0jU4Wzfo157g?=
 =?us-ascii?Q?tEXg6umbu9EAIJPa2JV8VZ1oleWJMo2UrKFVGwGmbOLsR1kXhSeKUbQmyazW?=
 =?us-ascii?Q?ifaoe2N5St5uC7on/pM8ihk58zBogSrCKn5d8yfA4gvwTtL/JwbdutONo/b5?=
 =?us-ascii?Q?Yto7JE9TXBQW7ZVevHvdogZI/BTbMpfKTqRPqh1OZY/tNrepJQiT8/XQRCo+?=
 =?us-ascii?Q?jvRV92vE+sbgy3j5QAgcBln5pBPsPJGXz3tRq9SCDV80bj3uV/AJi+W84217?=
 =?us-ascii?Q?rL4iPRtd6FfQzrUdeGpRAmyx4uC+2pNGC5p9JJpFEcqGBN7wSjRqJYiZVYZS?=
 =?us-ascii?Q?CTEr7rgRFhyuDWdQ4OnpwQaRMWoxLb/gz3Rur2wOCIvJWYeSAOMMoUm6VriM?=
 =?us-ascii?Q?5UfftTjX+57ZFqq40WxO2ZGRe7Tvd4OgVW71IEPvGmaUt0QfUiR1XDHlnXxa?=
 =?us-ascii?Q?mB7ffRFGsZrsI7XE0nKq3WXaPBQ5MBfGauMMN6W/k2WzV1EbnjWImO9ZP/dx?=
 =?us-ascii?Q?e/W8PPqdezqWfIzyUeE6yY9+?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5367
Original-Authentication-Results: rasmusvillemoes.dk; dkim=none (message not signed)
 header.d=none;rasmusvillemoes.dk; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: fb8b3ce6-9471-42a0-afcb-08d92fcc0acf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CIzYCBEHFqjvrhS2IlDcfaswVVUC2kuB9kvUIzJOqSwXOk41SWkgH0tktIBucxo4LhRY0BqCJ+WAE7UePdgau6LtnenKMDs1VO6C1XihDNey/GkEjBzMs0lVhrHcsMzpKWbsFB2Fx+dk0en+PduFlRsaysGlkJWiFDrNZwzrz3g5w+fPKsVrGZP8zT5hL3wwn9LXMNTSl4GoVmdyycmqbHiEcYGXRvTZB33JZ5Ij1ChoqBZDw5DliI+l6lR/bdfkx6o5jiTKpXlEDdzbJiNnAQuF0UkRwPQN0xRwCcNaZmvdmuIHEj8XaRc29vXqBrnjqEC3sloJ4q/AqnPF1kqfaoMUml7SArzkLLLmCnGQuupzsogeNJHR/BpXJOCyeCRlT5Omj6f6+jfhp7ZwSHpWVn1qbzz7U8DkjPEIVjxTPVqrMEsSawJgKdCn8wAk+By5Xaah0AvBQ1oTcqnd8JHamCe1p+bNx3ziZwVao/PaXJ4hOV/jC41aGNYCfi1Ii6Xw4jcIEs0Pcd1gdaIUgr3eHUl1EXpcULbUKBsXDPY4PU33bpYgWbmlXZsYzqYS5bTNNVyzmI9oENRmMX/tJp/UbIwuyX2LaQh0B5o10M24H8ZGo79Qs5E2N2FO8Dj8dQnQW5RkzbeCwBkfGe0UQxFsyMZD8+2kZxrysvBvzeQhQyw=
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(376002)(39850400004)(346002)(136003)(46966006)(36840700001)(81166007)(356005)(6506007)(83380400001)(7696005)(47076005)(82310400003)(26005)(70586007)(70206006)(36860700001)(53546011)(186003)(86362001)(82740400003)(33656002)(450100002)(5660300002)(8676002)(54906003)(110136005)(8936002)(478600001)(316002)(55016002)(2906002)(52536014)(336012)(4326008)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 07:06:20.5431
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd2483b-0785-4ca0-5a81-08d92fcc1408
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4148
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rasmus

> -----Original Message-----
> From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Sent: Saturday, June 12, 2021 5:40 AM
> To: Justin He <Justin.He@arm.com>; Petr Mladek <pmladek@suse.com>; Steven
> Rostedt <rostedt@goodmis.org>; Sergey Senozhatsky
> <senozhatsky@chromium.org>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Jonathan Corbet <corbet@lwn.net>;
> Alexander Viro <viro@zeniv.linux.org.uk>; Linus Torvalds <torvalds@linux-
> foundation.org>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>; Eric Biggers
> <ebiggers@google.com>; Ahmed S. Darwish <a.darwish@linutronix.de>; linux-
> doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> fsdevel@vger.kernel.org
> Subject: Re: [PATCH RFCv3 3/3] lib/test_printf: add test cases for '%pD'
>
> On 11/06/2021 17.59, Jia He wrote:
> > After the behaviour of specifier '%pD' is changed to print full path
> > of struct file, the related test cases are also updated.
> >
> > Given the string is prepended from the end of the buffer, the check
> > of "wrote beyond the nul-terminator" should be skipped.
>
> Sorry, that is far from enough justification.
>
> I should probably have split the "wrote beyond nul-terminator" check in t=
wo:
>
> One that checks whether any memory beyond the buffer given to
> vsnprintf() was touched (including all the padding, but possibly more
> for the cases where we pass a known-too-short buffer), symmetric to the
> "wrote before buffer" check.
>
> And then another that checks the area between the '\0' and the end of
> the given buffer - I suppose that it's fair game for vsnprintf to use
> all of that as scratch space, and for that it could be ok to add that
> boolean knob.
>
Sorry, I could have thought sth like "write beyond the buffer" had been che=
cked by
old test cases, but seems not.
I will split the "wrote beyond nul-terminator" check into 2 parts. One for
Non-%pD case, the other for %pD.

For %pD, it needs to check whether the space beyond test_buffer[] is writte=
n


--
Cheers,
Justin (Jia He)


IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.