Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Oded Gabbay' <ogabbay@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Koby Elbaz <kelbaz@habana.ai>
Subject: RE: [PATCH 2/9] habanalabs: zero complex structures using memset
Thread-Topic: [PATCH 2/9] habanalabs: zero complex structures using memset
Thread-Index: AQHXYRwQZE/ZQ83R6029wR0YI8AD3KsUvd1A
Date:   Tue, 15 Jun 2021 08:27:38 +0000
Message-ID: <0ad1aa7cc1504b759f997028c80a6bd6@AcuMS.aculab.com>
References: <20210614125100.17627-1-ogabbay@kernel.org>
 <20210614125100.17627-2-ogabbay@kernel.org>
In-Reply-To: <20210614125100.17627-2-ogabbay@kernel.org>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Oded Gabbay
> Sent: 14 June 2021 13:51
> 
> From: Koby Elbaz <kelbaz@habana.ai>
> 
> fix the following sparse warnings:
> 'warning: Using plain integer as NULL pointer'
> 'warning: missing braces around initializer'

Sparse is being over-enthusiastic.

...
> diff --git a/drivers/misc/habanalabs/common/firmware_if.c
> b/drivers/misc/habanalabs/common/firmware_if.c
> index 14e70422af25..d5d0db7fd6ef 100644
> --- a/drivers/misc/habanalabs/common/firmware_if.c
> +++ b/drivers/misc/habanalabs/common/firmware_if.c
> @@ -392,10 +392,11 @@ void hl_fw_cpu_accessible_dma_pool_free(struct hl_device *hdev, size_t size,
> 
>  int hl_fw_send_heartbeat(struct hl_device *hdev)
>  {
> -	struct cpucp_packet hb_pkt = {0};
> +	struct cpucp_packet hb_pkt;

Try just deleting the 0?
I think modern compilers allow {}.

	David

>  	u64 result;
>  	int rc;
> 
> +	memset(&hb_pkt, 0, sizeof(hb_pkt));
>  	hb_pkt.ctl = cpu_to_le32(CPUCP_PACKET_TEST <<
>  					CPUCP_PKT_CTL_OPCODE_SHIFT);
>  	hb_pkt.value = cpu_to_le64(CPUCP_PACKET_FENCE_VAL);
> --
> 2.25.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)