Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210614125100.17627-1-ogabbay@kernel.org> <20210614125100.17627-2-ogabbay@kernel.org>
 <0ad1aa7cc1504b759f997028c80a6bd6@AcuMS.aculab.com>
In-Reply-To: <0ad1aa7cc1504b759f997028c80a6bd6@AcuMS.aculab.com>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Tue, 15 Jun 2021 11:31:24 +0300
Message-ID: <CAFCwf10WzmED-c3ofsXxx309prcpo-wma_i+hcOdG3Ckg_a8DQ@mail.gmail.com>
Subject: Re: [PATCH 2/9] habanalabs: zero complex structures using memset
To:     David Laight <David.Laight@aculab.com>
Cc:     Oded Gabbay <ogabbay@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Koby Elbaz <kelbaz@habana.ai>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 15, 2021 at 11:27 AM David Laight <David.Laight@aculab.com> wrote:
>
> From: Oded Gabbay
> > Sent: 14 June 2021 13:51
> >
> > From: Koby Elbaz <kelbaz@habana.ai>
> >
> > fix the following sparse warnings:
> > 'warning: Using plain integer as NULL pointer'
> > 'warning: missing braces around initializer'
>
> Sparse is being over-enthusiastic.
>
> ...
> > diff --git a/drivers/misc/habanalabs/common/firmware_if.c
> > b/drivers/misc/habanalabs/common/firmware_if.c
> > index 14e70422af25..d5d0db7fd6ef 100644
> > --- a/drivers/misc/habanalabs/common/firmware_if.c
> > +++ b/drivers/misc/habanalabs/common/firmware_if.c
> > @@ -392,10 +392,11 @@ void hl_fw_cpu_accessible_dma_pool_free(struct hl_device *hdev, size_t size,
> >
> >  int hl_fw_send_heartbeat(struct hl_device *hdev)
> >  {
> > -     struct cpucp_packet hb_pkt = {0};
> > +     struct cpucp_packet hb_pkt;
>
> Try just deleting the 0?
> I think modern compilers allow {}.

The problem is we sometimes run on less-than-modern compilers...
So I prefer this method (memset). No harm is done here in any case.
Oded
>
>         David
>
> >       u64 result;
> >       int rc;
> >
> > +     memset(&hb_pkt, 0, sizeof(hb_pkt));
> >       hb_pkt.ctl = cpu_to_le32(CPUCP_PACKET_TEST <<
> >                                       CPUCP_PKT_CTL_OPCODE_SHIFT);
> >       hb_pkt.value = cpu_to_le64(CPUCP_PACKET_FENCE_VAL);
> > --
> > 2.25.1
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>