Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 10:48:13 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= <linux@weissschuh.net>
cc:     linux-input@vger.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] HID: input: Add support for Programmable Buttons
In-Reply-To: <20210520084805.685486-1-linux@weissschuh.net>
Message-ID: <nycvar.YFH.7.76.2106151047190.18969@cbobk.fhfr.pm>
References: <20210520084805.685486-1-linux@weissschuh.net>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, 20 May 2021, Thomas Weißschuh wrote:

> Map them to KEY_MACRO# event codes.
> 
> These buttons are defined by HID as follows: "The user defines the 
> function of these buttons to control software applications or GUI 
> objects."
> 
> This matches the semantics of the KEY_MACRO# input event codes that 
> Linux supports.

I have only a very small nit, otherwise I am fine taking the patch for the 
upcoming merge window -- could you please also briefly mention in the 
changelog the fact that you are adding support for a new collection type?

Thanks,

-- 
Jiri Kosina
SUSE Labs