Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 10:48:28 +0100
Message-ID: <87o8c7ihlf.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Yanan Wang <wangyanan55@huawei.com>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Eric Auger <eric.auger@redhat.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <kvmarm@lists.cs.columbia.edu>, <linux-kernel@vger.kernel.org>,
        <yuzenghui@huawei.com>, <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files
In-Reply-To: <20210615035019.35808-1-wangyanan55@huawei.com>
References: <20210615035019.35808-1-wangyanan55@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 15 Jun 2021 04:50:19 +0100,
Yanan Wang <wangyanan55@huawei.com> wrote:
> 
> These fixes introduce no functional change but just adjustment about
> coding style issues for ARM64 vgic code. They mainly include identation
> fix of function parameters/arguments, identation fix of structure
> initialization, identation fix of comment, also the deletion of some
> superfluous space lines.

Please don't. This sort of patches bring little value, and make the
backporting of important fixes more difficult because of pointless
context change.

Fixing these cosmetic details is fine when you are modifying the
code. But as a standalone patch, this brings more pain than benefit.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.