Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3610323pxj; Tue, 15 Jun 2021 04:56:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwifpXoEpQHlVbfcTXtuJOrkI7VM+AB1R7fmKfpQUwwlWOBV/m1ZPE/K0Zrkd4ot/GXaeV7 X-Received: by 2002:a02:a784:: with SMTP id e4mr21180926jaj.18.1623758216605; Tue, 15 Jun 2021 04:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623758216; cv=none; d=google.com; s=arc-20160816; b=jTCSNZ3MvPq4PwXNICFB64OB62VPUwc4tlgf+E/h0D9hG6GG/b8u+1tz9wUrRnFgW1 2ZjcqQPoQLoY5+Pn2OJmqd6j0sMErOn7yApuY5LrmM2ClM7w5SMzJJVKCdAAgOfcpEOi oB+MZl0Js1iMz1naWg4RQx8lI3/ioj5IzO2VKh6aMUB9ebMtq1mOs5MY/XYRQnLht+LZ 0KApbvp0ZzucVola5/pAhD7LhkcFSwg8uQ5DYc1phA7ADrqR16bYSPEu1iC52V/KiwWK PNt0uTKXF7Vh0pYRAOK7sb6g1B3hkNBaCMhf7eO99SLQh7OjqfwQdVfk3cgIryWpphBS w2ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:organization :dkim-signature; bh=paJlfJ3NUi9BTJrv4iZ5RAe2NIk2kE19q2VsrD4YODI=; b=UFPIHKq8Wgpp3JVCdyAqV+Wil8AHQinGGJscXvyNSdmVLLlkEOmoMmY3Wuu4qjmdNN 9WlMX6aj7LEcZGgF7so0hTpLhZ85BaM6N4qnzcZ8rpwtMZCQUKl0ag4kXhs6h5onbe89 WxFgwvvcm4peW3Ak8d/BJTv6B8syoMjc9qxdUJaPILTpysilPhX/DKIXzXz8Mw9VcaNZ PRKu0Zwdv2t6xJ4QFqRU/1VXRIMlbCzvnFUc7yoenVgBsoc2M/JAKjU0vlKJoJ+NCN1J nO55dvigguSKTt7Ybr9awNENCCv48UPGjpxUFld+kuVc+grv67k6FHxhXq/xzaMh1h5H gpEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UW275erf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si20365857jat.82.2021.06.15.04.56.44; Tue, 15 Jun 2021 04:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UW275erf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230269AbhFOL5n (ORCPT + 99 others); Tue, 15 Jun 2021 07:57:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54098 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbhFOL5m (ORCPT ); Tue, 15 Jun 2021 07:57:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623758138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=paJlfJ3NUi9BTJrv4iZ5RAe2NIk2kE19q2VsrD4YODI=; b=UW275erfcLhRrWd+EwMK4JILTwHnzEjDlfXdhS+MH6uevyb4Q+De2KeCD3IDAwo7r1aZS8 79pp4VDq7M4F6LplyeAqdjEuNRt3PEvZxIN52bV4WX4j+mhpVP+ZBxeNNtdnX6o4Bq/rbq DnlrpOkG5Ckyjr9GQNTYf+Eio2MhpBA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-Colm3IHUP36oStMHJL3tnw-1; Tue, 15 Jun 2021 07:55:36 -0400 X-MC-Unique: Colm3IHUP36oStMHJL3tnw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97B61100C660; Tue, 15 Jun 2021 11:55:34 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-65.rdu2.redhat.com [10.10.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6D98620DE; Tue, 15 Jun 2021 11:55:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH] afs: fix no return statement in function returning non-void From: David Howells To: torvalds@linux-foundation.org Cc: Hulk Robot , Zheng Zengkai , Randy Dunlap , Tom Rix , linux-afs@lists.infradead.org, dhowells@redhat.com, marc.dionne@auristor.com, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 15 Jun 2021 12:55:31 +0100 Message-ID: <162375813191.653958.11993495571264748407.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheng Zengkai Add missing return to fix following compilation issue: fs/afs/dir.c: In function ‘afs_dir_set_page_dirty’: fs/afs/dir.c:51:1: error: no return statement in function returning non-void [-Werror=return-type] Fixes: f3ddee8dc4e2 ("afs: Fix directory handling") Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai Acked-by: Randy Dunlap cc: Tom Rix cc: linux-afs@lists.infradead.org Link: https://lore.kernel.org/r/20210327121624.194639-1-zhengzengkai@huawei.com/ --- fs/afs/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 78719f2f567e..c31c21afd2e1 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset, static int afs_dir_set_page_dirty(struct page *page) { BUG(); /* This should never happen. */ + return 0; } const struct file_operations afs_dir_file_operations = {