Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3610425pxj; Tue, 15 Jun 2021 04:57:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSQ9Jf24KrOC2YmYPB1LxIwWaOYtOh0qJPhBDKwRbXUdRs/bENIxR8UR8qkZ+qA8F42B6q X-Received: by 2002:a05:6402:6d1:: with SMTP id n17mr22987973edy.116.1623758226866; Tue, 15 Jun 2021 04:57:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623758226; cv=none; d=google.com; s=arc-20160816; b=jJ4AFXBw8LJ6zq7NcZ/8JRpZZoC3poPMcGVM3Z+pr3mk3DXcRIC5x7UEuV8lT86zHS yLOYGMJSzhxjdgn2whaoHb6TIwDb3pjFJmKnbHrrycy7bxg0SQ1dk+zZCNW8NLgc99xe Wf5nEiQ8sWZO6D7gZPV2DGpIw7tvXdikY6JMa9U2sC2YiY5/lD1O8snaQZIaLkQBsosD FoHMu4tDCxQBORQdg985hSOZ2GPdsCHpDJg4QZYd2UyQj/47E6FGaEQ8Yh/SugQtK6qn 2hJhDUzfZ6YjKcKsEA+2a2FemcZuxCTymORUAQSkPuYU+dUnzK/9jVOO6hqUf265Kd4T ttcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=zhfBKMIwPlpYKPDu6wLozPOVxi6MQKtRzt/w6ijw5Aw=; b=ms7vkYZzFlc3PFjM3RSztU0aK5fNgUZpp4O3UM6HTO2MLju6qG3X/BDcjY07/6UiFV /mUVNmVxDgDeMGZNRN0kEiE73ytUFANgW8KAudhJW8pG9+aF2jsiKYDw8pxfhtvJCLLs caWO5WnCWYGr99WpPYcKELQ2Vxn+mAJ9SM35X59o2zFFXyHB7x3ySHWZixthPxguWO1r P7+Zu/fRH/vLutcCyvUYH5J3c0Az9SGfYVn8vUxPN6sYouJTKfwuFatHXF1kG+yRd8uU yiWNKy2BcHXonwIM05uMtVomNOKCFs/8S3Tm1DV2nLEGMUl4BRv9YXFv1/U4EPKXrPh7 EnVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e2rvcPjF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gg8si13867773ejc.230.2021.06.15.04.56.42; Tue, 15 Jun 2021 04:57:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e2rvcPjF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbhFOL5E (ORCPT + 99 others); Tue, 15 Jun 2021 07:57:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230161AbhFOL5B (ORCPT ); Tue, 15 Jun 2021 07:57:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 863D660FF0; Tue, 15 Jun 2021 11:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623758097; bh=Ryg5gVD62jasf3/gyRRVCZbE2fmZc8ABQmAVPplc3YA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e2rvcPjFxkpDpzhUpoLfrAMqWsulNem2IX3ZJDmuUWk5+Cxf8x4Rl87KomsEp9RK+ +W3y7leleoManvGA37ngEuDjurweGrouI3y7HpPq34Ct2kjbQPYJI0Vd5d53LWTa0T Wr/bQB0ffYDxBGH2bqtsy3BeUHMAMsTUNAObO8JvnfrK/JmJVVx5uHNMEK5SyPGsJr 8mj1L5oTHhTuF7wOggMK2Iw6fpVqDwGLTzLSWNTyN89zP/GjMDXEBshNza6BS+l5Yn awpcsJtM97d0lezlo9+QEFDCR8x/1Butyy7fQsZqR0300FKqbhR4Bw0GuGxtSXDm8p RU/FLDkjswD2Q== Date: Tue, 15 Jun 2021 12:54:38 +0100 From: Mark Brown To: Claudius Heine Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Marek Vasut , Kuninori Morimoto , Sia Jee Heng , Pierre-Louis Bossart , Michael Sit Wei Hong , Miquel Raynal , Annaliese McDermond , Matthias Schiffer , open list Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Message-ID: <20210615115438.GD5149@sirena.org.uk> References: <20210615094933.3076392-1-ch@denx.de> <20210615094933.3076392-2-ch@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline In-Reply-To: <20210615094933.3076392-2-ch@denx.de> X-Cookie: See store for details. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > With this change it will be possible to add different code paths for > similar devices. > static const struct i2c_device_id aic32x4_i2c_id[] = { > - { "tlv320aic32x4", 0 }, > - { "tlv320aic32x6", 1 }, > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, > { /* sentinel */ } It appears that the device already supports multiple variants? --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDIlP0ACgkQJNaLcl1U h9CYOwf/SlCmc7TAjtDwrSiQvdXEdliXBwxX5qNaJe+XWlWNKdt6nxq00rCJ4kH5 YOfjOL/FvF9oCEnUqdQSBOKiiLTPxtUVZPbUCZsaLC9h6euOxLVvmsMWRGvGBYeb O7Mfcuvik8fX4TtQPrlN+VkSKuHNprrMeyBlVV8t5r84ED39c63uWDa56WvY5J6S P/ZRzT1ZVVpJC0418lE+y+dnnzegalwiZTn2u4mFxyN+CrD7OC2GfDFROFO9IAcT 0PfaHIHrj5k+JdNqQUVGKeAgp77W7Tb9fdepVkGxYK4lw8RTlgFqjpSPpPVu2WId PPiI4st8jlpxYJOb9fg8ReQfQ9MMyQ== =F81b -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/--