Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3619533pxj; Tue, 15 Jun 2021 05:08:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+6jDxtlw2wKR0zjdO30hsqYtWlgMtangs0wsfwnk6uTSYjk2BrViN4aTDDRpUR8uA7bMq X-Received: by 2002:a17:906:1982:: with SMTP id g2mr20505917ejd.184.1623758894489; Tue, 15 Jun 2021 05:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623758894; cv=none; d=google.com; s=arc-20160816; b=c9mi8JOoqrZO0LLZzw3sBYIg3bScFFbBkUp8fxfJaVSRKOuB+6N6PT3KSmDu81ITBv 9PAvibQmumkFN0xMVG3z7b3l1HPwQylw1AOOlal7ggdQcV1eNYkmhaqnNHkmbBis6k0x m2fWZOV7J4SjFa9tAYl3IV/FTRCVQIfXQDfcmHRkjeujgateULUNbvAtZLGUxNwAiMHN aGvliySDzxG4CpwT2XaYaRl3Ep7NjECI8cdI41azZdN2WUKXdZMXRk1iYpvcv0gDBRK/ NZqxoLWNc0/QxUeBt0MM9DlmOIUro0tZDGHu70k9sMkwTcjjEQgzshVeI/YZXJMS0V4n Cn8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:dkim-signature; bh=dWaYxNZ7Ro9xr/pNtB1Q08hiDs2nyh+0Dls0ENGlbRs=; b=MXHtlwevFB80q7ARiqMYAX59N1XU/R9QNe2TYOP8gufWP+g3XUcZcONpFXkTfBoNon FKoxkRo5cxiRnnR9/Wcm1fCf5ZR1n7NKxvwzMoc8Un19+1BTY/vsmepvXzQCbv2iZ+Me J/4aAtHXivXPTVZz7NYF8W/YzIi45BnaZ0Ixt6lu5BMuiFxDwSZTAUJPLtaDHEPx3ZXb BlqHq0VwGkcrd1Q5p3vCsaSEbXQEYb1i3QmaCx+nrGagRj7FwAlkFf2IODgRO3vn67w9 VC+eNaEvd2XcN4lJTZgsi6NGpKtprcmm2K1PzBUb5ZdYFzncn7SEw490Gaq+OFKSnLdc 6i8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=wePmA+OF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 18si8738424ejd.227.2021.06.15.05.07.49; Tue, 15 Jun 2021 05:08:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=wePmA+OF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbhFOMIh (ORCPT + 99 others); Tue, 15 Jun 2021 08:08:37 -0400 Received: from phobos.denx.de ([85.214.62.61]:53924 "EHLO phobos.denx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbhFOMIh (ORCPT ); Tue, 15 Jun 2021 08:08:37 -0400 Received: from [10.88.0.186] (dslb-084-062-104-230.084.062.pools.vodafone-ip.de [84.62.104.230]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ch@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 21FAD81249; Tue, 15 Jun 2021 14:06:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1623758791; bh=dWaYxNZ7Ro9xr/pNtB1Q08hiDs2nyh+0Dls0ENGlbRs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=wePmA+OF/i3IITNVBaahj2vBUdygQswycdQHdo6wNsv8QQZOdoVDbVNIIXS1IaTSp unfn5UOCllYXnrLUjilB5CUonIU5saosGc1hLsvxCnvUrbhG8R0sqd3qeV9a1XX2Xr kBvCYBvb8dESS22C4IRoBLQO/whP9JkvmnYvngCutMkgmECxP2qRqDTXa3VWiq/Y3x irnq3zwamU9psotPDU91/0s5/d5hjW42HQV51N9UpMGDwocKDP2xU7bS8RLAtXdHjl 1tbiGHIvB2Xnvww7SPiP8DknBA1JvkO6ma04M1h7oaTpkfDSIwab41Dwkq/jvQ6YoB g3r1+yRIZZUng== Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Marek Vasut , Kuninori Morimoto , Sia Jee Heng , Pierre-Louis Bossart , Michael Sit Wei Hong , Miquel Raynal , Annaliese McDermond , Matthias Schiffer , open list References: <20210615094933.3076392-1-ch@denx.de> <20210615094933.3076392-2-ch@denx.de> <20210615115438.GD5149@sirena.org.uk> From: Claudius Heine Organization: Denx Software Engineering Message-ID: <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de> Date: Tue, 15 Jun 2021 14:06:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210615115438.GD5149@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 2021-06-15 13:54, Mark Brown wrote: > On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > >> With this change it will be possible to add different code paths for >> similar devices. > >> static const struct i2c_device_id aic32x4_i2c_id[] = { >> - { "tlv320aic32x4", 0 }, >> - { "tlv320aic32x6", 1 }, >> + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, >> + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, >> { /* sentinel */ } > > It appears that the device already supports multiple variants? Those values aren't used anywhere as far as I can see. regards, Claudius