Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] io_uring: Fix comment of io_get_sqe
To:     Fam Zheng <fam.zheng@bytedance.com>, linux-kernel@vger.kernel.org
Cc:     Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org,
        fam@euphon.net
References: <20210604164256.12242-1-fam.zheng@bytedance.com>
From:   Pavel Begunkov <asml.silence@gmail.com>
Message-ID: <9ab231e1-bb3f-9f18-ac17-9dc3b1a35135@gmail.com>
Date:   Tue, 15 Jun 2021 14:02:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210604164256.12242-1-fam.zheng@bytedance.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/4/21 5:42 PM, Fam Zheng wrote:
> The sqe_ptr argument has been gone since 709b302faddf (io_uring:
> simplify io_get_sqring, 2020-04-08), made the return value of the
> function. Update the comment accordingly.

Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>

> 
> Signed-off-by: Fam Zheng <fam.zheng@bytedance.com>
> ---
>  fs/io_uring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 903458afd56c..bb3685ba335d 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
>  }
>  
>  /*
> - * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory
> + * Fetch an sqe, if one is available. Note this returns a pointer to memory
>   * that is mapped by userspace. This means that care needs to be taken to
>   * ensure that reads are stable, as we cannot rely on userspace always
>   * being a good citizen. If members of the sqe are validated and then later
> 

-- 
Pavel Begunkov