Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3686355pxj; Tue, 15 Jun 2021 06:34:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu1vZ/bwgSb/tkVeurq7sNOsYBnGy9RFPBJt3yhDP6jlPp43DXlFgz6gEqrNwShMdC45Xq X-Received: by 2002:a17:906:49ce:: with SMTP id w14mr21175309ejv.273.1623764071293; Tue, 15 Jun 2021 06:34:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623764071; cv=none; d=google.com; s=arc-20160816; b=CABGNy3+3oHw0PEzbXS30L38gD5+z00ci2RAwZ/7Dhk4ol+CK4P+0JDaW4FUOIcdXO XeOJHzqKZ1SAO3HgrR8tgp5uBS5LiNbW7dg2JEoqSwfUuryKe3jydhd65F3e4RfqnM5p t9hw4/d5TV+Ppu/2kwUjyGeD96zbFdT/+ArCwKmj8fNrRYi7pZPN74NjLc8eYjrY1rCl NZSBZDB9FSFi4MdtQuXy2Ds9Tp7ZfYJwWjVb3hOCU9n8AVzmwZRUXuG21NNaZvI6lSeu 5XSucxjLdeztFzzz9xw3MSwh/NWfOVWNSGllvIJCxjfSCKp+yk0OrNmpDPj95w7G4S6O Us/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yNm0xt4kGxCCPmpAIxoWiXM9BSg0d3z2x7bNSyY8esc=; b=hvSnExSGDDkgOpcwbxTWSznOpFTiGROfUdZpT11Xt/9OTn51EtbFQjKx9hGVh/oXKa JazmiZ+R4DJKbawuVl/DMc384O+gVZIRwhAmyn+CZ/p6qS4jCFc+GaEqi9KRL+x+jVWB tVqA41fR2QgBBH67B+eavNQ7CA/Hs9dUcIPBfdXLf8pZ59vT1vKRybVQMKfWy122giw1 YyX4gAZa/bsX47LEwDR9RREkZQel5lPMA+NjPfU4Tx5k2AV2XWjE2yLHQxNwLGALf9Cr tLev7t3QDMl0RDeELC+Vn4bY4Y7jBzW2C6dYBEi21a5v2Dc4ZvGDbPHYbLQbQ40M5pTv MTQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=D6ilb4oL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si14451900ejm.186.2021.06.15.06.34.07; Tue, 15 Jun 2021 06:34:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=D6ilb4oL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbhFONc2 (ORCPT + 99 others); Tue, 15 Jun 2021 09:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231623AbhFONcM (ORCPT ); Tue, 15 Jun 2021 09:32:12 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AA47C06114B; Tue, 15 Jun 2021 06:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=yNm0xt4kGxCCPmpAIxoWiXM9BSg0d3z2x7bNSyY8esc=; b=D6ilb4oLkW64fDzc7RCsTtlloB +OAlU5dAR6vYRW2dn0Mdws68N1JiSIh0LhXlp+ULb1Yi2PIQLDEkH6b0q+cFDuvdnNvEIJm4/Qtoq s0GWFhBDTeBGOrTO3OtnlMajKze9ZpPqfCFfEhyKfCqXNWV3RMAdq81syNPfVWUgEAmAot0a14OFJ +VRP6NIcbxB6qYnYS6Hohpx4eH18y6ErearZGrTk3H0cbOrS6y+EOzzPWh/ai/6I+yS/XHj+uSbb4 qAoNOOBTvykSnu4Ogq3h04hYu2YguvsFlGs+++qWequrxvP1nh3ymiSV0/UimY8IzBfMTp8XpZgfk dVLQhkPA==; Received: from [2001:4bb8:19b:fdce:9045:1e63:20f0:ca9] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt96d-006o7a-Nx; Tue, 15 Jun 2021 13:28:02 +0000 From: Christoph Hellwig To: Jens Axboe , Thomas Gleixner Cc: Thomas Bogendoerfer , Geoff Levand , Ilya Dryomov , Dongsheng Yang , Mike Snitzer , "James E.J. Bottomley" , Ira Weiny , dm-devel@redhat.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, linux-arch@vger.kernel.org Subject: [PATCH 09/18] rbd: use memzero_bvec Date: Tue, 15 Jun 2021 15:24:47 +0200 Message-Id: <20210615132456.753241-10-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210615132456.753241-1-hch@lst.de> References: <20210615132456.753241-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use memzero_bvec instead of reimplementing it. Signed-off-by: Christoph Hellwig Acked-by: Ilya Dryomov Reviewed-by: Ira Weiny --- drivers/block/rbd.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 531d390902dd..501a10bfb1fe 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -1219,24 +1219,13 @@ static void rbd_dev_mapping_clear(struct rbd_device *rbd_dev) rbd_dev->mapping.size = 0; } -static void zero_bvec(struct bio_vec *bv) -{ - void *buf; - unsigned long flags; - - buf = bvec_kmap_irq(bv, &flags); - memset(buf, 0, bv->bv_len); - flush_dcache_page(bv->bv_page); - bvec_kunmap_irq(buf, &flags); -} - static void zero_bios(struct ceph_bio_iter *bio_pos, u32 off, u32 bytes) { struct ceph_bio_iter it = *bio_pos; ceph_bio_iter_advance(&it, off); ceph_bio_iter_advance_step(&it, bytes, ({ - zero_bvec(&bv); + memzero_bvec(&bv); })); } @@ -1246,7 +1235,7 @@ static void zero_bvecs(struct ceph_bvec_iter *bvec_pos, u32 off, u32 bytes) ceph_bvec_iter_advance(&it, off); ceph_bvec_iter_advance_step(&it, bytes, ({ - zero_bvec(&bv); + memzero_bvec(&bv); })); } -- 2.30.2