Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Punit Agrawal <punitagrawal@gmail.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     pmladek@suse.com, senozhatsky@chromium.org, rostedt@goodmis.org,
        john.ogness@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition
References: <20210614235635.887365-1-punitagrawal@gmail.com>
        <8c16059d-6e58-a3e4-25ef-7e2bcabecd86@rasmusvillemoes.dk>
Date:   Tue, 15 Jun 2021 22:36:33 +0900
In-Reply-To: <8c16059d-6e58-a3e4-25ef-7e2bcabecd86@rasmusvillemoes.dk> (Rasmus
        Villemoes's message of "Tue, 15 Jun 2021 08:50:45 +0200")
Message-ID: <87im2ftfku.fsf@stealth>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Rasmus,

Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:

> On 15/06/2021 01.56, Punit Agrawal wrote:
>> Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
>> improving readability by removing vprintk indirection, inadvertently
>> placed the EXPORT_SYMBOL() for the newly renamed function at the end
>> of the file.
>> 
>> For reader sanity, and as is convention move the EXPORT_SYMBOL()
>> declaration just after the end of the function.
>> 
>> Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
>> Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
>> --
>> Hi,
>> 
>> The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while
>> attempting to rebase the RT patches onto newer kernels.
>> 
>> Generally I avoid sending trivial changes on their own but this one is
>> a little hard to overlook. Also it felt like an obvious oversight in
>> the original patch.
>
> Yes, indeed, sorry about that, and thanks for fixing it.
>
>> Please consider merging.
>
> Petr, as this is causing trouble for the -rt patchset, please consider
> if this could make it to Linus before v5.13 release.
>
> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Thanks for the quick response.

Punit