Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3691945pxj; Tue, 15 Jun 2021 06:41:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTRaNU8ZxteTz7hbHdvaIJLr1er5g+2Uy72oonZ4hoBHNCU1iu/sp3o/Z5CJq7rX55U5wY X-Received: by 2002:aa7:cd42:: with SMTP id v2mr23581228edw.245.1623764498110; Tue, 15 Jun 2021 06:41:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623764498; cv=none; d=google.com; s=arc-20160816; b=yBneCMvrNfZxCXy2f89LgGaJX3G/PnmbDQ937jbRm/IIiKIAvurzJOt75y4GhfaX5x 4xisfl8dVaM4k/e7F/1vy0cFCQzQxgGmaGStbwYQX78qm2+Ph6XQZgsR/Hw05IcUyu1a Oan3O/E3UdZn7tejbPWB1VxqAtX684uJIds44HNN3ouQsdPqtT1omELtkcutG1zh88X0 JKDREcrs4RZYLYYp5qtd2JFCvy9ADhd5Hpg7xs4w0eYW/Ui9sh4E1Gq1doqrZoVysrLS eZ9hU0kqjURMMA78Mazo1NI8jmKLbMLjwAkdni/0i44ixIJsZObVjpsTqTqXMkIfLdIb gG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Srxve+7vV8IOAPBXFoVfzq8tqssoJ0JJIIUP7PVz0Ig=; b=NHE4CKtHUEDfLq8NbU6nt+6ZRP8dTDoKMzQcvLNvrVMVO5NgjSL5+dRNhWE0xdSUsC xJAmtnZqSNUqY1foQZC2SSXJVvDibXDi+5TFhclueVLOg/eAawEh0XrHhs4f2ptQxC4I 4uVOrICGZu65WNwXUHLOYWfceCf6ma7sjdYRVf0e5ulGP4IGXPEvwN0KLal4MXwsC55L oiKKpf3B+LAWbmfHqKqiC01QlkvDGkGO2u5m6tKFfIy4laDyobuXHVc7q7sMUg+1Cesq W3cTOMQAtnMj1O48VkAHtQEg8e9aaz7o+NE2nAidiZTMKMQM/1XN5JC+HEPrVmUjWKPx WDrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si14604535ejo.404.2021.06.15.06.41.14; Tue, 15 Jun 2021 06:41:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231732AbhFONkq (ORCPT + 99 others); Tue, 15 Jun 2021 09:40:46 -0400 Received: from verein.lst.de ([213.95.11.211]:49069 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231817AbhFONkJ (ORCPT ); Tue, 15 Jun 2021 09:40:09 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4EF4667373; Tue, 15 Jun 2021 15:37:58 +0200 (CEST) Date: Tue, 15 Jun 2021 15:37:58 +0200 From: Christoph Hellwig To: Claire Chang Cc: Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , tfiga@chromium.org, bskeggs@redhat.com, bhelgaas@google.com, chris@chris-wilson.co.uk, daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jxgao@google.com, joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Subject: Re: [PATCH v10 01/12] swiotlb: Refactor swiotlb init functions Message-ID: <20210615133758.GA20389@lst.de> References: <20210615132711.553451-1-tientzu@chromium.org> <20210615132711.553451-2-tientzu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615132711.553451-2-tientzu@chromium.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 09:27:00PM +0800, Claire Chang wrote: > Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct > initialization to make the code reusable. Looks good, Reviewed-by: Christoph Hellwig