Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Matthew Wilcox <willy@infradead.org>,
        David Mozes <david.mozes@silk.us>
Cc:     "linux-fsdevel\@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Darren Hart <dvhart@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: futex/call -to plist_for_each_entry_safe with head=NULL
In-Reply-To: <YMZkwsa4yQ/SsMW/@casper.infradead.org>
References: <AM6PR04MB563958D1E2CA011493F4BCC8F1329@AM6PR04MB5639.eurprd04.prod.outlook.com> <YMZkwsa4yQ/SsMW/@casper.infradead.org>
Date:   Tue, 15 Jun 2021 17:03:34 +0200
Message-ID: <87k0mvgoft.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jun 13 2021 at 21:04, Matthew Wilcox wrote:
> On Sun, Jun 13, 2021 at 12:24:52PM +0000, David Mozes wrote:
>> Hi *,
>> Under a very high load of io traffic, we got the below=C2=A0 BUG trace.
>> We can see that:
>> plist_for_each_entry_safe(this, next,=C2=A0&hb1->chain, list) {
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 if (match_futex (&this->key, &key1))
>> =C2=A0
>> were called with hb1 =3D NULL at futex_wake_up function.
>> And there is no protection on the code regarding such a scenario.
>> =C2=A0
>> The NULL can=C2=A0 be geting from:
>> hb1 =3D hash_futex(&key1);

Definitely not.

>> =C2=A0
>> How can we protect against such a situation?
>
> Can you reproduce it without loading proprietary modules?
>
> Your analysis doesn't quite make sense:
>
>         hb1 =3D hash_futex(&key1);
>         hb2 =3D hash_futex(&key2);
>
> retry_private:
>         double_lock_hb(hb1, hb2);
>
> If hb1 were NULL, then the oops would come earlier, in double_lock_hb().

Sure, but hash_futex() _cannot_ return a NULL pointer ever.

>> =C2=A0
>> =C2=A0
>> This happened in kernel=C2=A0 4.19.149 running on Azure vm

4.19.149 is almost 50 versions behind the latest 4.19.194 stable.

The other question is whether this happens with an less dead kernel as
well.

Thanks,

        tglx