Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 12:06:30 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "Alex Williamson (alex.williamson@redhat.com)" 
        <alex.williamson@redhat.com>, "Raj, Ashok" <ashok.raj@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Robin Murphy <robin.murphy@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        David Gibson <david@gibson.dropbear.id.au>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Jason Wang <jasowang@redhat.com>
Subject: Re: [RFC] /dev/ioasid uAPI proposal
Message-ID: <20210615150630.GS1002214@nvidia.com>
References: <MWHPR11MB1886422D4839B372C6AB245F8C239@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210528233649.GB3816344@nvidia.com>
 <MWHPR11MB188621A9D1181A414D5491198C3C9@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210603130519.GY1002214@nvidia.com>
 <MWHPR11MB1886BA2258AFD92D5249AC488C309@MWHPR11MB1886.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR11MB1886BA2258AFD92D5249AC488C309@MWHPR11MB1886.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (47.55.113.94) by MN2PR16CA0041.namprd16.prod.outlook.com (2603:10b6:208:234::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15 via Frontend Transport; Tue, 15 Jun 2021 15:06:31 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1ltAe6-0079oU-FK; Tue, 15 Jun 2021 12:06:30 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8b9433e7-c070-415c-697c-08d9300f288e
X-MS-TrafficTypeDiagnostic: BL0PR12MB5555:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL0PR12MB555516F047EFB7DCF1A29B57C2309@BL0PR12MB5555.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: sAbG2xvgezLOd8oNewffTlPP/DJzsnJMk+yrbALIwy/JzmdsXH8I6RYPw4MMDH6AqTNy+zBi82eWHsXiu0P2VCoI9ZMdEO6fxVwetPjM8/Cq97RRIN4wZ31Rm+F26L2IWUmT80XK/x7qKGxYGRPp0CDHBGlCRPiC/vcy74lw94BtktLF+fEy8gzhElOkzYN/bf3N665ebth+ny73/AVUqhHeUZ0PjGRy35t9DBOUJU7cwIn2Prqs6X+XrSRXCpU+BzIHofczT42O8jiE9P1XbbhheoSrqUru6YHJH8YWnxSSo8bep62jtZofry3kxNCVkdX2j1e+baOV/PRigccnaEpA3IWHNgBdgTx0o3MV1B56MkGEqMXtstN9XU2zChepVNFfOEGaVY9LplIFdi6026PXJYi/yLskwgb5LAz0lOQz8RiWE97xJmBEyo8ymuvTvIRKB1yAGHiDyuBgGn/eWL6B7Wq39LA2YudlhaDLm78c8bWvpUKxqmhNI1uTxgTd50RE225cQZ29+TdL3Br7cqLJlNg7h9rn7/DFm1yiCiAeW6LP8wzSFf8/gaTbGQI0Y9zMyaf5YWhqyvWL1PG4eFGaancIhyrYyAPwlAKVsaI=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(66556008)(36756003)(26005)(4326008)(8676002)(426003)(8936002)(2906002)(66476007)(1076003)(86362001)(186003)(33656002)(478600001)(9786002)(6916009)(316002)(54906003)(7416002)(9746002)(38100700002)(66946007)(5660300002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HZkkB0IIx1hJqDAH6df8kOXmtG74WGGyBl3ZS1/YEhT7GTwrOIWUp5iDc4nt?=
 =?us-ascii?Q?SCX8hPHYLci8L1qgy0evezToTyxwBjnGmD8rLuPUJtTgVS4QZgFX9tCwamgm?=
 =?us-ascii?Q?8wd8/ccB/nXhEicSNamCIQdd6HHzgG6U8lWYSyufaXVrNcrT/gspJcn325ij?=
 =?us-ascii?Q?LyjXeJUkeWYQxUjHxrSF/JqWm7BDh+RNdcMVwGzyQlkZ70+DJTKP4LeqeqDh?=
 =?us-ascii?Q?F3rJUQl8MN7uuotOSbj1Nr5PcaU1Pa5Jg24dcfYjvF5P4oO559eVyiZdfuia?=
 =?us-ascii?Q?wxDOrfBU17KJCwGubGg6N3UQQnx8vXqvLcLmH0EB+XsR70Mkq/DyBYwkvo8c?=
 =?us-ascii?Q?03dkGuepsnC7hflg/TMHni/jxPtVuEzTredZAtsszpXVr5VIW8E8SAAsBRrY?=
 =?us-ascii?Q?VP4nYAV0hV93lHB36//EamSzr0BY//Sn1QDdx7kVU5MHRrdmQc/DDM+KCAIO?=
 =?us-ascii?Q?akq+N4e20Ly/5/F1780m9Q2PUWpEvil5N5Y+N3Q9xCjLSnkuW2JBnAwOLTRc?=
 =?us-ascii?Q?7VAaJoAJTfhurbrAmfHn5v9a5GSHKSAFfR5lhwLp9Y9ivHuETzS0X7svphV7?=
 =?us-ascii?Q?jqF6ME8ChZgzAgZ5Nb5LWzi7M358Xa+OZpRgjPbf+aWnuo3lrhthB6mS4sYQ?=
 =?us-ascii?Q?oY54jeHdWbidol0KVnWh62AJtfVjzstSMyazCzq2UOYto9dskwxHerksvVsW?=
 =?us-ascii?Q?CjZSXyegECqhDy6k5qytvBkYW1BFRGjp1ADB0T3GJoqWEVu+QadIx1NAyyLe?=
 =?us-ascii?Q?ved1JZyr03Xv9AQHoJfrMg21aclug57a6f9hXcef4Rtvy+Tjs8fBVUyADrYp?=
 =?us-ascii?Q?5//rJFnS5xUvQEFRIvvfEwo51OZscn4ie4CLbxxWC/8Asdz6In3WGOs12YDa?=
 =?us-ascii?Q?n9OYcC13sFVx+6a2tJL3RZwWlY/ozQhtmJbUx1C9f7RJfLQVp17mBlivziGI?=
 =?us-ascii?Q?9/U18YWEXY74zQ+oXbIjt7f7FfU9wucuyVS8Zj1+k/sdCxw+ru1w+Nqvtj2X?=
 =?us-ascii?Q?7Poe4PqdwLOQS7Iq5ErkzbA4xwoSVqEW6O80cs8LP95VuB4mqQruO20iz3I8?=
 =?us-ascii?Q?QOwqF4lbeEH32IwbZljiz4upYV408d0L9L7OihG+tOJWlgPAZIvabqEqHQXK?=
 =?us-ascii?Q?4NDz1JA2K5tdxazRyf5axYNkOn6QwMpnae38gwkbyMfrfPaIKijJ9pfMzk66?=
 =?us-ascii?Q?yW+nMghYB5VkfjgBvI9sRMUfwg5KZlZxd/5Xq0KlWCW2NqpVSptsj1KgnDhU?=
 =?us-ascii?Q?PUIXo66PPk95egXXzQi3uvX9aM2uKsnZPrAfcJPz4RH2dxb0p/TZ2qcl/zXi?=
 =?us-ascii?Q?RljBSWcjM5QRiVRHqv/+zeCq?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b9433e7-c070-415c-697c-08d9300f288e
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 15:06:31.4203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pVTinr38/J62LtioJluhC9GaMzd4IwGYaqkUdk5jtehTbFYOa6kEvuzo7ycVCJsQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5555
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 15, 2021 at 08:59:25AM +0000, Tian, Kevin wrote:
> Hi, Jason,
> 
> > From: Jason Gunthorpe
> > Sent: Thursday, June 3, 2021 9:05 PM
> > 
> > On Thu, Jun 03, 2021 at 06:39:30AM +0000, Tian, Kevin wrote:
> > > > > Two helper functions are provided to support VFIO_ATTACH_IOASID:
> > > > >
> > > > > 	struct attach_info {
> > > > > 		u32	ioasid;
> > > > > 		// If valid, the PASID to be used physically
> > > > > 		u32	pasid;
> > > > > 	};
> > > > > 	int ioasid_device_attach(struct ioasid_dev *dev,
> > > > > 		struct attach_info info);
> > > > > 	int ioasid_device_detach(struct ioasid_dev *dev, u32 ioasid);
> > > >
> > > > Honestly, I still prefer this to be highly explicit as this is where
> > > > all device driver authors get invovled:
> > > >
> > > > ioasid_pci_device_attach(struct pci_device *pdev, struct ioasid_dev *dev,
> > > > u32 ioasid);
> > > > ioasid_pci_device_pasid_attach(struct pci_device *pdev, u32
> > *physical_pasid,
> > > > struct ioasid_dev *dev, u32 ioasid);
> > >
> > > Then better naming it as pci_device_attach_ioasid since the 1st parameter
> > > is struct pci_device?
> > 
> > No, the leading tag indicates the API's primary subystem, in this case
> > it is iommu (and if you prefer list the iommu related arguments first)
> > 
> 
> I have a question on this suggestion when working on v2.
> 
> Within IOMMU fd it uses only the generic struct device pointer, which
> is already saved in struct ioasid_dev at device bind time:
> 
> 	struct ioasid_dev *ioasid_register_device(struct ioasid_ctx *ctx,
> 		struct device *device, u64 device_label);
> 
> What does this additional struct pci_device bring when it's specified in
> the attach call? If we save it in attach_data, at which point will it be
> used or checked? 

The above was for attaching to an ioasid not the register path

You should call 'device_label' 'device_cookie' if it is a user
provided u64

Jason