Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 11:39:25 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "libaokun (A)" <libaokun1@huawei.com>
Cc:     <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
        <weiyongjun1@huawei.com>, <yuehaibing@huawei.com>,
        <yangjihong1@huawei.com>, <yukuai3@huawei.com>
Subject: Re: [PATCH -next] tracing: Remove set but not used variable 'ret'
Message-ID: <20210615113925.27ad04ea@oasis.local.home>
In-Reply-To: <4ab45eeb-ad26-03e8-f2c5-2dc4582a2946@huawei.com>
References: <20210527091032.3878436-1-libaokun1@huawei.com>
        <4ab45eeb-ad26-03e8-f2c5-2dc4582a2946@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, 15 Jun 2021 09:59:10 +0800
"libaokun (A)" <libaokun1@huawei.com> wrote:

> ping
> 
> 在 2021/5/27 17:10, Baokun Li 写道:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > kernel/trace/trace_events_hist.c: In function 'unregister_field_var_hists':
> > kernel/trace/trace_events_hist.c:5228:6: warning:
> >   variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >
> > It never used since introduction.

Which was a bug.

> >
> > Signed-off-by: Baokun Li <libaokun1@huawei.com>
> 

This was fixed differently:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6c610dba6e2beb1a16ac309672181d0090fb8d30

-- Steve