Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210509184519.15816-1-alex.nemirovsky@cortina-access.com>
 <20210509184519.15816-2-alex.nemirovsky@cortina-access.com>
 <YMiUpK/+PjsoCU1W@kroah.com> <CFD14D63-4537-4A91-861C-71B74E2CFAE6@cortina-access.com>
 <YMi1jOL6y+eUK3Df@kroah.com> <B71C5D02-EDBE-4AAD-AF1B-2FD467BE075A@cortina-access.com>
In-Reply-To: <B71C5D02-EDBE-4AAD-AF1B-2FD467BE075A@cortina-access.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 15 Jun 2021 09:44:21 -0600
Message-ID: <CAL_JsqKDf9W-1KHUoFFCoLareLKf0CAVMU6CXR22xW3hWM_8yg@mail.gmail.com>
Subject: Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART
 to json-schema
To:     Alex Nemirovsky <Alex.Nemirovsky@cortina-access.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jason Li <jason.li@cortina-access.com>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
<Alex.Nemirovsky@cortina-access.com> wrote:
>
>
>
> > On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation=
.org> wrote:
> >
> > On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> >> MAINTAINERS modification was made in the initial version 1.  We made n=
o changes to it since then,
> >> thus not sure what we could at to  Changelog which would add value or =
clarity for others
> >> from the v1.
> >>
> >>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundati=
on.org> wrote:
> >>>
> >>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> >>>> From: Jason Li <jason.li@cortina-access.com>
> >>>>
> >>>> Convert the Cortina-Access UART binding to DT schema format.
> >>>>
> >>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >>>> ---
> >>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++=
++
> >>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> >>>> MAINTAINERS                                   |  6 +++
> >>>
> >>> You are also adding a MAINTAINERS entry here, which is not listed in =
the
> >>> changelog text, so I couldn't take it anyway :(
> >
> > Add the maintainers entry in the first patch, with the driver please.
>
> The change to MAINTAINERS here add a new file into the DT documentation.
> Should it not be grouped into the dt-binding portion and reviewed by the =
DT time for which this patch
> is CC=E2=80=99ed to? Why would moving the DT documentation file that is i=
ntroduced be into the first patch, which is the
> serial driver itself be the correct approach?

The binding doesn't actually need a MAINTAINERS entry (though having
one is fine). get_maintainers.pl will also pull emails from the
binding schema.

Rob