Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     Yafang Shao <laoar.shao@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched, fair: try to prevent migration thread from preempting non-cfs task
In-Reply-To: <CAKfTPtDj6E00o4ZFDJ+kJKqy8J3oLm-mVSajUnHpufFCRiX_8g@mail.gmail.com>
References: <20210615121551.31138-1-laoar.shao@gmail.com> <87mtrrb2jw.mognet@arm.com> <CAKfTPtDj6E00o4ZFDJ+kJKqy8J3oLm-mVSajUnHpufFCRiX_8g@mail.gmail.com>
Date:   Tue, 15 Jun 2021 17:39:52 +0100
Message-ID: <87im2faxpj.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 15/06/21 17:45, Vincent Guittot wrote:
> On Tue, 15 Jun 2021 at 16:55, Valentin Schneider
> <valentin.schneider@arm.com> wrote:
>> This can be summarized as in the below, no?
>>
>>                         /*
>>                          * Don't cause a higher-than-CFS task to be preempted by
>>                          * the CPU stopper.
>>                          */
>
> IMO, it's worth keeping the explanation that we are there because:
> - a CFS task that was running during the 1st step :  if
> (busiest->nr_running > 1) { ...
> so we didn't pull the task
> - but it has been preempted while lb was deciding if it needs an
> active load balance
>
> so maybe something like:
>                          /*
>                           * Don't kick the active_load_balance_cpu_stop,
>                           * if the CFS task has been preempted by higher
>                           * priority task in the meantime.
>                          */
>

Ack