Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 13:07:02 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
        <mhelsley@vmware.com>, <peterz@infradead.org>,
        <samitolvanen@google.com>, <yj.chiang@mediatek.com>
Subject: Re: [PATCH v2] recordmcount: Correct st_shndx handling
Message-ID: <20210615130702.0292284e@gandalf.local.home>
In-Reply-To: <20210615163245.26164-1-mark-pk.tsai@mediatek.com>
References: <20210615114229.3b1f2c5f@oasis.local.home>
        <20210615163245.26164-1-mark-pk.tsai@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 16 Jun 2021 00:32:45 +0800
Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:

> > On Tue, 15 Jun 2021 14:47:20 +0800
> > Mark-PK Tsai <mark-pk.tsai@mediatek.com> wrote:
> >   
> > > One should only use st_shndx when >SHN_UNDEF and <SHN_LORESERVE. When
> > > SHN_XINDEX, then use .symtab_shndx. Otherwise use 0.
> > > 
> > > This handles the case: st_shndx >= SHN_LORESERVE && st_shndx != SHN_XINDEX.
> > > 
> > > Reported-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > > Tested-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>  
> > 
> > Please explain the two signed-off-by's above. If you are just tweaking
> > Peter's original patch, please add at the start:
> > 
> > From: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> > And then just above your signed off by, add what you changed:
> > 
> > Tested-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > [ Changed something ]
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > 
> > But state what you changed.
> > 
> > Thanks!
> > 
> > -- Steve  
> 
> Sorry for messing up.

No problem. It's a learning process.

> I've fixed it in v3.

Thanks,

-- Steve