Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: UNpnCLGQANDcr/qCbw85QUSYuDFZQQdMuDYPAJG/MiS4hglw4sAr+Y8L05i8+jzJmhdLC0G/Mc
 SyFJv6iXeqVA==
IronPort-SDR: 5iTgW6+ws4jEnyNlU3RUF9nhigIOUYsUmFXk+4X6oPHLKj73muhySis6uWczgCr7QgyyuJcV4k
 QqL8jq5zxsag==
Subject: Re: [PATCH v4 12/24] x86/resctrl: Group staged configuration into a
 separate struct
To:     James Morse <james.morse@arm.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        shameerali.kolothum.thodi@huawei.com,
        Jamie Iles <jamie@nuviainc.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        lcherian@marvell.com
References: <20210614200941.12383-1-james.morse@arm.com>
 <20210614200941.12383-13-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <20699528-e26b-bc81-c8bd-af26ba14a9c3@intel.com>
Date:   Tue, 15 Jun 2021 11:08:59 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210614200941.12383-13-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi James,

On 6/14/2021 1:09 PM, James Morse wrote:
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 8fa806c85cec..8fad1af8f15e 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -23,13 +23,21 @@ enum resctrl_conf_type {
>   	CDP_DATA,
>   };
>   
> +/**
> + * struct resctrl_staged_config - parsed configuration to be applied
> + * @new_ctrl:		new ctrl value to be loaded
> + * @have_new_ctrl:	whether the user provide new_ctrl is valid

user provide -> user provided?

Reinette