Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3936231pxj; Tue, 15 Jun 2021 11:47:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmMw/Co+MohHqawjUmuEsgiRkaBjRfyryGDSR+7vXf214hcBhA8KlbMTNs//YoE4SA8t0H X-Received: by 2002:a05:6402:42cb:: with SMTP id i11mr1202617edc.242.1623782825122; Tue, 15 Jun 2021 11:47:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623782825; cv=none; d=google.com; s=arc-20160816; b=yW1cawkZPitfMHV7d0zKg+ZNBEbYM/b4j1UrMhsUJBvpGw5msGq4eLBDIXZeLvZycN aecE2pqknH7fegmNVaJggfwQBoi7jXPHNtGzQ+9PwFMJw2SMMaO55Qm9uV5vPy7PZn3Y CW1Ft3pU3uMIp27x0+m5fkjEPFNtEczZ71IzZkxc1CXjM4/7VFnRlsxdrG+nGldqPcXo brXj85n8CbSM5ohHr+nioKilgK7QsMdMdkyci70mD6WrIav4//3RI4PWivDFwaststLm EkX+YZ20XSOhaBarBqCqvKrvUWpGuGyL1mg1QCFAOBT1YjsaTCNcH3IOi5nVlQ1c1OVc i2BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:mime-version :ironport-hdrordr:ironport-phdr:ironport-sdr:dkim-signature; bh=LSLEA8uny0SvK6BuP9EUGLzKH3cmbfNsLY8/jivrk4k=; b=Dlu/EkTbL5M11i55NPMWMlwI9XWxbnogpp7HsDUtM/YLIHU8op/081H66WhQcANsiX 31kWHJ1vHufIfawNjAjPB055WDU81bnhSUItb5xu3dq1WtjNEmTe+M5MLlY1b88Lj3eT MrWZtRtLOZyFq8NVpy9pEMEJ4a/DzqJ6EOEmJxxVVhDoFBOB7TNq9G7EJIwlX0Q3CDdj dF6oSU09B4T/EtiPNek4MSdqYKkLSujJ2DdZZa+w+Gtwtc6+dyBsGXXLVSiZQ4bRtgCY SPdZJZeI8SrGRGS/dyjwDAAyvKK3tnP8v23Gx4FDB4UmK4oeXC/UwJV+sG3Pz0PwiEoI yh5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ucr.edu header.s=selector3 header.b=cXrOVS6+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ucr.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c8si14708892edr.306.2021.06.15.11.46.42; Tue, 15 Jun 2021 11:47:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@ucr.edu header.s=selector3 header.b=cXrOVS6+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ucr.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbhFOSr5 (ORCPT + 99 others); Tue, 15 Jun 2021 14:47:57 -0400 Received: from mx.ucr.edu ([169.235.156.38]:46809 "EHLO mx-lax3-3.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbhFOSr5 (ORCPT ); Tue, 15 Jun 2021 14:47:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1623782753; x=1655318753; h=mime-version:from:date:message-id:subject:to; bh=VwHEffF6WEd8HZtGBpsh6YDP+gKybrkud0rCfHHpekU=; b=cXrOVS6+0HDqq4AALlNuZjTBjvkYAC1/4FLYp6lwZVuupzdfZA88Bl78 FLza+yNOkU692YpI9uMOlNvlJYOhiI9oUAa8jWIbzoUhOv6E9gdiYBh96 a0J8BwQfHhk/VPMCNDUcDilotiI8pXFhqGFjtYVYKJlJqdK1rzg46WYet KlQ2MN7A7sfuEM0mT2gozqy41K5H7hWEEQRUWrg2viqHiXwmZAQcTQe50 wYFK0XFkZaeW6aOfAxSTUQ7WuMTR+jAWQ+OihYHqSFqFcoVokxWQ3WH+V ScKwiWcGeB1+6WSr9a/G6lDD76PfZCAyDAdwljOlZy0hpQfccFH3SpSnT g==; IronPort-SDR: jgxBQ1emycBFOis6CObs9cR/fIBVNaUlykQ/p3BzIa/OpmZjwbK0na7hLxJAiVOv2HUOqjvmx9 ybW7r+xlLB9cJvscIpcx6IcoPOC0l++YA1qhJTr8aq8UHDFcu8sSFcAmlK6Ibp8a5ji3m/530W zbsDPAt6AiNod+WmhuyidHYLJnVl0unx3sLLOkrZhVmgTwWRcYk/Qir5l0LzyJb56xIyijf5Lb CTkKQGO2ZTy30KlOm9oMRbJbJq1oRw77kJmOnCfQjFw6tIdKAcj1c+vFyqGYmxnOFPZcqjBaDJ v60= X-IPAS-Result: =?us-ascii?q?A2E5AgAG9chghsfXVdFagQmBV4N4bIRIlSgBmCWBfAIJA?= =?us-ascii?q?QEBD0EEAQGHOwIlNAkOAgQBAQEBAwIDAQEBAQUBAQYBAQEBAQEFBAEBAhABA?= =?us-ascii?q?QEBbIUvRoI4KQGEBREEeA8CJgIkEgEFASIBEiKCT4MInGWBBD2LMn8zgQGIJ?= =?us-ascii?q?wEJDYFiEn4qhwmCZ4QhgimBS4I3dIQLg1CCZASDGXsTg3YBAQGeM5xgAQYCg?= =?us-ascii?q?wMbnXgrlGqQewGVVKRNECOBMYIVMxolfwZngUtQGQ6OOI5VJC84AgYKAQEDC?= =?us-ascii?q?YcVgkcBAQ?= IronPort-PHdr: A9a23:K/H8ABNnLsgl8PkoB4Ml6nZWChdPi9zP1u491JMrhvp0f7i5+Ny6Z QqDvKQr1wWWFtqAo9t/yMPu+5j6XmIB5ZvT+FsjS7drEyE/tMMNggY7C9SEA0CoZNTjbig9A dgQHAQ9pyLzPkdaAtvxaEPPqXOu8zESBg//NQ1oLejpB4Lelcu62/229pHJbQhEmjiwbbxwI Ri4sA7cqtQYjYx+J6gr1xDHuGFIe+NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S 6dYDCk9PGAu+MLrrxjDQhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85 Kl3VhDnlCYHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6jAf90VWHBBU95eWCJBDI2yb JYBAfQdMutDs4nxu0EDoQeiCQWwBu7izCJDiH/s3a091uQsCQPJ3A0hHtIOrXTUq8j+O6QSU e+vzanD0DLObvNX2Df98ofIcwwtre2CUL9rbMre1VMvGxnbgVqNtIzoJjWY3fkCvGaH9eRvT /6vi3I5pAFrpDii3sYhh43Ui48LxF7K+zh0zZs1K9GmVUJ3f9qpHIZRui+VNYZ7Td0uTmB2t Cs+1rELt4K3cSoExpg6yRPSd/iKfoaO7xn+V+iROS91iGx5dL+7nRq/8kitxvfiWsWp0FtGt DdJn93Iu30Lyhfd8NKISuFn8UekwTuP0gfT5fxaLk0sjqrbLoIhwqY3lpoOrUTPBi/2l1vyj K+Rbkgk//Kn6+XjYrn/vp+cOJJ4hhjwMqgznsGyBf40MgcJX2ic9uS80KPs8VflT7VNi/06i qjZsJbEKsQHvqO1HRNZ34I55xu8DzqqysoUkWQHIV5fZR6Ki4zkN0nLIP/iDPe/h1qskC1sx /DDJrDgApTMLnjZn7fgYbpx90BRxREuzd9D/ZJYEK8OL+/uWkPprtzXEgc5MxCow+bgENh90 oIeWWSSAq6WKa/SskGH5vgpI+aSYI8Yoyj9K/c76P70l3M5mkESfbOv3ZQJbHC0BPNmI1+WY SmkvtBUNG4XpA12Z+XwllSGUTkbTHa/X6s2rmU+A4KrDY7JboOgmrqM2GG8BJIAIihPCVmWE DHhdoGZQN8IaSSPMolglCAJUf6qTIplnT60uQCy6KBgJ+qR2iQCqZfq0pAh6PfemhIy3Th1C dmN3WaQSW19gmIPQXkxxq8p5QR/116Fze5xh/BVHPRc4vpIVkExMpuYh+h7Dc3iHwfMctaAY EipT8/gAjwrSN81hdgUbAI1H9SkkwCGxDajDL4TmJSPBYco6eTY3n7sN4BxxmiCnK0giUQ2B 8hCL2urgoZh+AXJQY3EiUOUk+Ctb6tP8jTK8TKyzHiOoUYQYg55UO2RTGIfb0qO9Y/R+0jYC bKiFOJ0YUN61ceeJ/4SOZXShlJcSaKmYYyGC18= IronPort-HdrOrdr: A9a23:A9lLZqiZYKjHZM2wKTad3NyTY3BQXtMji2hC6mlwRA09TyX4rb HIoB11726WtN98YhEdcLO7WZVoI0msl6KdiLN5VdyftWLdyQ6Vxe9ZnO/fKv7bdhEWNNQ26U 6tScdD4RTLYTZHsfo= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="5.83,276,1616482800"; d="scan'208";a="51733529" Received: from mail-pg1-f199.google.com ([209.85.215.199]) by smtp-lax3-3.ucr.edu with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jun 2021 11:45:50 -0700 Received: by mail-pg1-f199.google.com with SMTP id x7-20020a63db470000b029022199758419so9367494pgi.11 for ; Tue, 15 Jun 2021 11:45:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=LSLEA8uny0SvK6BuP9EUGLzKH3cmbfNsLY8/jivrk4k=; b=IXhz4Vgn5YinUovcioNrSBmaJ/2PPohXG/cRRlKqLJ7XwcpjOuCbx5EyTPbKXF+Fry rRClr6ayQmUfPFZi8VgWa2oFdYACZqGUm2KDktJNBJ8k83GAPTNKH1SStCbYpG3bolzG VNZJzFkpkH7rI7M0Lw09r8LYa2Rq6E16m5nvHyg3f6o8+XQJ/QTO/hgQEXMwxhuAsFwe fvu+atLjGrAgfiw9U+sObUuRXE/7nNz9ogpDNU+QJ1d7JIp7mEu+QYXMBzjp81N/w/ix neeCHZRac7d/IN+UeSJr1Absz4eBFSPPdnWjgb7YGVGQgAeomDHdPLWL1wQ8Vv5EVKGP N1rw== X-Gm-Message-State: AOAM530cP2bzjeTqJ+lE9FibrjPsWFG7G1YBcWP/CAMvGyZAZbCScmPi /dCQdJx2jmN2+MP6y9Zt1QqrTSxBTkHOUDpLRvB8RtRHibqQxTCX6JdxTJRHl4O9R/Nq4eMNW5f rborTfDvyNYziw7tNtY9fpKPTJ7+Xe9SnUI6Dq9QpCw== X-Received: by 2002:a05:6a00:a1e:b029:2e2:89d8:5c87 with SMTP id p30-20020a056a000a1eb02902e289d85c87mr5849455pfh.73.1623782748929; Tue, 15 Jun 2021 11:45:48 -0700 (PDT) X-Received: by 2002:a05:6a00:a1e:b029:2e2:89d8:5c87 with SMTP id p30-20020a056a000a1eb02902e289d85c87mr5849431pfh.73.1623782748638; Tue, 15 Jun 2021 11:45:48 -0700 (PDT) MIME-Version: 1.0 From: Yizhuo Zhai Date: Tue, 15 Jun 2021 11:45:38 -0700 Message-ID: Subject: [PATCH] media: atomisp: fix the uninitialized use To: Mauro Carvalho Chehab , akari.ailus@linux.intel.com, Greg Kroah-Hartman , juant.aldea@gmail.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Inside function mt9m114_detect(), variable "retvalue" could be uninitialized if mt9m114_read_reg() returns error, however, it is used in the later if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c index f5de81132177..8ddddb18ffbb 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c @@ -1534,12 +1534,15 @@ static int mt9m114_detect(struct mt9m114_device *dev, struct i2c_client *client) { struct i2c_adapter *adapter = client->adapter; u32 retvalue; + int ret; if (!i2c_check_functionality(adapter, I2C_FUNC_I2C)) { dev_err(&client->dev, "%s: i2c error", __func__); return -ENODEV; } - mt9m114_read_reg(client, MISENSOR_16BIT, (u32)MT9M114_PID, &retvalue); + ret = mt9m114_read_reg(client, MISENSOR_16BIT, (u32)MT9M114_PID, &retvalue); + if (ret) + return ret; dev->real_model_id = retvalue; if (retvalue != MT9M114_MOD_ID) { -- 2.17.1