Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3953002pxj; Tue, 15 Jun 2021 12:08:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/Al606IvN2RqliUiNV7T/P9ciyrUgfVGCBmCrmLuV8TdsYWwTxbxEvLg6/gJgxmBVWmol X-Received: by 2002:a92:c56d:: with SMTP id b13mr701357ilj.267.1623784120594; Tue, 15 Jun 2021 12:08:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623784120; cv=none; d=google.com; s=arc-20160816; b=b1LLQY8kil2ffC/mcuRi7aLKjUk3KFtd4AiSRoEYFf4gPOE2YJXTtZd8miKU5i7xJZ O2hZvBEbuMnHXWCY4E2S0UaWFylJEBCTOsF4/mW7mniMMUp1iP7tndOOvkoRz7GO+0Mn 1aL+hjsCjuHIdyeNJXrKA+DiTQyikptFqVO4xO9sOCHi+oARX92Y6eMh6NNFazgjRqJN ttqL4PHBBkKi2kJRp/2l1ySW90gX0nQ8eWRJgjS85AY5qSK+9l9VjUdQrhertumqWZ1Q Lw6OFwYWm+WzaRAWC+03yGLUYfLPSCLgfuOG1tKei/BtkahTMHkdKE7OtVi+UOLFOVMY Y8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=/2BblplUVZDT58n4HQMdwC2devrkLIjTioetJuumzdM=; b=vu+L0uvwJxqaYakCwdlHWOXgTjTK8G7po0hicLAk1hyM3Z9GDsenJiMk79wxsMOiD9 1/T4d85uV29zf2Zh8EWY8fl6ZEDNOKBp8QbrHELEDHtwQunjIXug+vH6E8nRdu/96wW/ Acj/jpxJOYa1IdJ76W5RMRpFgUfAMbxasUOH2VP5/M8V2NuAjdruJiwLw6G8XfVZ9zuE k1mj64K/+dJuFYoDD0dP1rZ/cRHcjdDtNP1xZDXkQjxI+UWtHqo8RlHn2Hc1GtgoFaN8 D1/kmRqzg8vtahmYOZK9CnKoVE7ytSYak+8OSzTaMK4RcJ9AJ7Oz+Iom84nW/5EqeTg+ KifQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm1 header.b=gvA+vmNT; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=nIWXQWhS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si21486494ilh.42.2021.06.15.12.08.27; Tue, 15 Jun 2021 12:08:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm1 header.b=gvA+vmNT; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=nIWXQWhS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231610AbhFOTIm (ORCPT + 99 others); Tue, 15 Jun 2021 15:08:42 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:43793 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbhFOTIk (ORCPT ); Tue, 15 Jun 2021 15:08:40 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 97CD216D6; Tue, 15 Jun 2021 15:06:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 15 Jun 2021 15:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=/2BblplUVZDT58n4HQMdwC2devr kLIjTioetJuumzdM=; b=gvA+vmNTW6SQ/yRcCeCc8RnklKzplFOAIG8fNSzh9L+ 8XtSYhIxME9ZU1GuXL/KHiSeVQPIOGSQ0ed0sBOlOsZSwOl9uVyPHZ+lD/EX/nZ+ ooio3NmE0fOAXIliC8eBH69p8USXauj3RKx0faQqosQ6/ajh5gWC+KE2qfcKvVHb /i4oYHcBu/is6SbpcEEILMzp/fDrH9q8uFdsGsBHCkAl8LE9TLfchjH1PeEpy0Q/ wR+WpuJCovcZKV8LrVNe4plvaXmxpGqdgIouRDwtEN4W6/7sPvLJYO6LFa9WnxZD sO0Wus8l10f/V5JlI+HMFZPQOaAoGKwWRvUq0V1LR0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/2Bblp lUVZDT58n4HQMdwC2devrkLIjTioetJuumzdM=; b=nIWXQWhS4GKFXNzjNSdEBA RFicbQJhGGgswI/uVrquDNEWqbEwzQPmVmcJpaa8MtPa8K8zgWDRm53KcP31D0xl uJ0jLzHtsUqLXdr36C7189126kHKtEsbLkz8EPaDu040brcWDIROmh0mJg2agXPH mks9/jhHyV+n7WCZUyqvJC15jRL8npdobd8ZMag1mvlMAz3PAh4K3DLSoI8vMeQj O/MrTPeI5xZwZkfpUSsjO7gPt8z8D3wX9WAY6x5476FmxF59yFYEYhv3xSqGoHXv zvv/2nY6KGLj6vPUuf9j33oTzn9eDKiDaK9DEzq/kPUjZffuqVYBHbDQN8HDKanw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvjedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Jun 2021 15:06:33 -0400 (EDT) Date: Tue, 15 Jun 2021 21:06:31 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v4 4/4] remoteproc: core: Cleanup device in case of failure Message-ID: References: <1623783824-13395-1-git-send-email-sidgup@codeaurora.org> <1623783824-13395-5-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623783824-13395-5-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 12:03:44PM -0700, Siddharth Gupta wrote: > When a failure occurs in rproc_add() it returns an error, but does > not cleanup after itself. This change adds the failure path in such > cases. > > Signed-off-by: Siddharth Gupta > Cc: stable@vger.kernel.org > --- > drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) Why is this needed for stable kernels? And again, a Fixes: tag?