Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 20:09:08 +0100
From:   Paul Barker <paul@pbarker.dev>
To:     Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Use python3 to run spdxcheck.py
Message-ID: <20210615200908.0000367c@pbarker.dev>
In-Reply-To: <CABJPP5Ch4oTnrVZxSO3qLXO2M0xawLJpBO-T5+L7EJDRH3s1Hg@mail.gmail.com>
References: <20210615185206.7701-1-paul@pbarker.dev>
        <CABJPP5Ch4oTnrVZxSO3qLXO2M0xawLJpBO-T5+L7EJDRH3s1Hg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 16 Jun 2021 00:28:14 +0530
Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:

> On Wed, Jun 16, 2021 at 12:22 AM Paul Barker <paul@pbarker.dev> wrote:
> >
> > Since commit d0259c42abff ("spdxcheck.py: Use Python 3"), the
> > shebang line in scripts/spdxcheck.py says the script should run
> > with `python3`. However, checkpatch has been explicitly running
> > this script with `python` so it needs updating to ensure that
> > Python 3 is used on all distros.
> >
> > Signed-off-by: Paul Barker <paul@pbarker.dev>
> > ---
> >  scripts/checkpatch.pl | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 23697a6b1eaa..5e5e3a53461b 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1084,10 +1084,10 @@ sub is_maintained_obsolete {
> >  sub is_SPDX_License_valid {
> >         my ($license) = @_;
> >
> > -       return 1 if (!$tree || which("python") eq "" || !(-e
> > "$root/scripts/spdxcheck.py") || !(-e "$gitroot"));
> > +       return 1 if (!$tree || which("python3") eq "" || !(-e
> > "$root/scripts/spdxcheck.py") || !(-e "$gitroot"));
> >
> >         my $root_path = abs_path($root);
> > -       my $status = `cd "$root_path"; echo "$license" | python
> > scripts/spdxcheck.py -`;
> > +       my $status = `cd "$root_path"; echo "$license" | python3
> > scripts/spdxcheck.py -`; return 0 if ($status ne "");
> >         return 1;
> >  }
> > --  
> 
> Hello,
> This change was already added by Commit c739ec2da1ea
> ("checkpatch: scripts/spdxcheck.py now requires python3")
> in linux-next.
> 
> Thanks,
> Dwaipayan.

So it is. Apologies for the noise.

-- 
Paul Barker
https://pbarker.dev/