Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4055247pxj; Tue, 15 Jun 2021 14:30:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvbJeBsvefTbbwm092G0Yyo5gBUNdsmWuxJbywRzDhl/dYwh57WYQg0qJWAaSaIeRee62c X-Received: by 2002:a92:bf02:: with SMTP id z2mr1058452ilh.27.1623792633921; Tue, 15 Jun 2021 14:30:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623792633; cv=none; d=google.com; s=arc-20160816; b=aqlrk9yDl6xVYm/b1L5tYSbJyOCaMjr5kSu05ly+OwLnzXA85V1ipp44TZBAUuySA1 9bjKbqIvLVyilBlu//T1TVY5MwK9BXpadk7jP4x6G4tZ28gc7i+xDSU+zvU0tqI05BCG IRVs5AoOV8jRTd1p+ZdKw6H0OGpdIzbPO6kiPyEkPed/oJfJv1Wn6mixoBlUX3XnCWD1 De3bsf+Ir/l/jRVeBFtYgTLi4eOB2yory2y09HXTDGPLFd6NgVcoq2Q8JL6JASaGxAlS 0HpkPdDgeM+a7COc1TJJ2hNZUnmrv6AhY5Bti3is09PnpBlE56KF6vwPUaBTaDoCtt9u ajGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Z8l5pyigZ4sAnWmGuyoEt4UlPIHTvZnCXuw0L/8f19g=; b=Rajne10is0iOxFTVw4Kf65hcwgI93us9bj2KAncKy0fB9boG4hdPyCEwf2xT/HYHio DUsWY37L7atXYvCGhwW1pB7xkp4h1dNNxQMW0fY4k2Kuh3NVvj3Jsp05nq0fmGMpie1g Ho37RXgs+x2uFtfCpOJlrsbEG2maC4zTawBgNcrZotwVkgBRvwcI0JX5mC8hjCJ3BszU mu0s/rIG6FtY2KZX+j5eeshk5bH8NB6xXDvudMT1pWuOW96no4h/FICZesaoNjmJwVxy m5sYKDLQGY1ZgoaIH6BVx/oVnYc2e2NItgKwYbn8PAwgz9baZvH3is+dxmSRFvaqCgwn h7VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a2814pRm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si21928818iom.40.2021.06.15.14.30.20; Tue, 15 Jun 2021 14:30:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a2814pRm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhFOVba (ORCPT + 99 others); Tue, 15 Jun 2021 17:31:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:54754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbhFOVba (ORCPT ); Tue, 15 Jun 2021 17:31:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 07F8361078; Tue, 15 Jun 2021 21:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623792565; bh=Z8l5pyigZ4sAnWmGuyoEt4UlPIHTvZnCXuw0L/8f19g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=a2814pRmpC9A/dY7FIW1TXMw+SNYEGGICYHjniea7HulIIKgftR8IWPa4cllk80KJ bnKFSdaFURxllZ9BqaeUwoCXTuQVadtvDiRWIQlTG554bqzN/zGLTgSsJj/7jeFZnb E7ydAA47Zyq274qGLkcf1ov3tzuhI6t65y6lAHOpKxRS6qt1ce9JlvSwk6E/ehP8Yg XfXrG47A6zNZQw2JOVJd5KhQWpqbtmYG367TdFCBXkX7X7JkbfBzbcT9OQgCt0Ijk7 M5Jj8+K5ya3+0/J3YG+cIulZx4CIqH9CqiWEL5VomGw2CSGI07JLvTa1ftKzL4o2RI MHXvxCHK2grQA== Received: by mail-ej1-f53.google.com with SMTP id gt18so75364ejc.11; Tue, 15 Jun 2021 14:29:24 -0700 (PDT) X-Gm-Message-State: AOAM530GwU7zVYx79tIsjeljTQL1yQnk9iFU3oxMShHVqCMcVnLDqsCD dntBqdy0qGaHDLArwwS6ZKRqjmHdLHYsEq7PNg== X-Received: by 2002:a17:907:3da4:: with SMTP id he36mr1668881ejc.108.1623792563457; Tue, 15 Jun 2021 14:29:23 -0700 (PDT) MIME-Version: 1.0 References: <20210607112856.3499682-1-punitagrawal@gmail.com> <20210607112856.3499682-5-punitagrawal@gmail.com> <3105233.izSxrag8PF@diego> In-Reply-To: <3105233.izSxrag8PF@diego> From: Rob Herring Date: Tue, 15 Jun 2021 15:29:12 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: Update PCI host bridge window to 32-bit address memory To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Bjorn Helgaas , Punit Agrawal , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , "linux-kernel@vger.kernel.org" , PCI , Alexandru Elisei , wqu@suse.com, Robin Murphy , Peter Geis , Ard Biesheuvel , Brian Norris , Shawn Lin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 3:50 PM Heiko St=C3=BCbner wrote: > > Hi, > > Am Montag, 7. Juni 2021, 13:28:56 CEST schrieb Punit Agrawal: > > The PCIe host bridge on RK3399 advertises a single 64-bit memory > > address range even though it lies entirely below 4GB. > > > > Previously the OF PCI range parser treated 64-bit ranges more > > leniently (i.e., as 32-bit), but since commit 9d57e61bf723 ("of/pci: > > Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses") > > the code takes a stricter view and treats the ranges as advertised in > > the device tree (i.e, as 64-bit). > > > > The change in behaviour causes failure when allocating bus addresses > > to devices connected behind a PCI-to-PCI bridge that require > > non-prefetchable memory ranges. The allocation failure was observed > > for certain Samsung NVMe drives connected to RockPro64 boards. > > > > Update the host bridge window attributes to treat it as 32-bit address > > memory. This fixes the allocation failure observed since commit > > 9d57e61bf723. > > > > Reported-by: Alexandru Elisei > > Link: https://lore.kernel.org/r/7a1e2ebc-f7d8-8431-d844-41a9c36a8911@ar= m.com > > Suggested-by: Robin Murphy > > Signed-off-by: Punit Agrawal > > Tested-by: Alexandru Elisei > > Cc: Heiko Stuebner > > Cc: Rob Herring > > just for clarity, should I just pick this patch separately for 5.13-rc to > make it easy for people using current kernel devicetrees, or should > this wait for the update mentioned in the cover-letter response > and should go all together through the PCI tree? This was dropped from v4, but should still be applied IMO. Acked-by: Rob Herring