Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: +8/jSYjLkhupzhzz4G6l+HTC1wQGpOSjfJeeyh4hNIZY+dqejjh2+i5Y8f+f5kAVgW59eWHpAE
 rli53Nr9bDxQ==
IronPort-SDR: JXvR4/83KixOWKKZTPv7+BD3IQAS7CYEL0uzdCxoJ+YEpPRtSO4F+KA6xQZPYrsSXanduDSZTP
 RRo8Zh75SxNA==
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "Alex Williamson (alex.williamson@redhat.com)" 
        <alex.williamson@redhat.com>, "Raj, Ashok" <ashok.raj@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Jonathan Corbet" <corbet@lwn.net>,
        Robin Murphy <robin.murphy@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "David Gibson" <david@gibson.dropbear.id.au>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Jason Wang <jasowang@redhat.com>
Subject: RE: [RFC] /dev/ioasid uAPI proposal
Thread-Topic: [RFC] /dev/ioasid uAPI proposal
Thread-Index: AddSzQ97BhCb3gd8AUyldaDZ6yOMNABTUTCAAQiuDaAADwOFgAJSmyVgAA0fjwAAEFKEEA==
Date:   Tue, 15 Jun 2021 22:59:06 +0000
Message-ID: <MWHPR11MB1886E9553A5054DF7D51F27D8C309@MWHPR11MB1886.namprd11.prod.outlook.com>
References: <MWHPR11MB1886422D4839B372C6AB245F8C239@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210528233649.GB3816344@nvidia.com>
 <MWHPR11MB188621A9D1181A414D5491198C3C9@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210603130519.GY1002214@nvidia.com>
 <MWHPR11MB1886BA2258AFD92D5249AC488C309@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210615150630.GS1002214@nvidia.com>
In-Reply-To: <20210615150630.GS1002214@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2v5tIACr1uIYKMxTGBjs1cmS5HoLvy3YDv2uCMIo5c1h1dcUvsltwH0ODUs1?=
 =?us-ascii?Q?EnksDCIZPupNgfksPes/sX7dZC3EeEPFTHEqBFTyUrmMcnHZ3acv04Llp/Uc?=
 =?us-ascii?Q?cvga06E2Bq7LxrxzyTrZwWZQuwdQnP0fTDaK3CQIbYpmL/KYZuIfg1Gx7Rmj?=
 =?us-ascii?Q?XcjETWy+ZOk/Q38FzgtlE9jjYi84L7jUxS+1Rbk6529M+e6LUBZW/0MXooO0?=
 =?us-ascii?Q?CWwQK3xxSbIlopz4KsjtPG4xjv4hB8Tl7W4MKjsK/vWiFpefamsSxBcIzL0Q?=
 =?us-ascii?Q?kxDXibDad95gay9a2AQ9iM2C9fVIf4Ftg2W2OCVEE/8PB++Dkk487AnnoChI?=
 =?us-ascii?Q?OQvoaKyBkyU4QJ8q0PUwxB/fUIKynBdn4i5DxW12pT1eb4k8iHkmdGEEUXVV?=
 =?us-ascii?Q?vxVIS/JdyrbnHyXdWpWdYCZru7omJJHceG1InGVCMT0Asl6uxz11nN1+gFks?=
 =?us-ascii?Q?XW0dqZ+Urc5S8y+hGP7vJNprTruca1Et7Z0v/Hr8I2VuQgwSbcfZ2neUUW57?=
 =?us-ascii?Q?8hkT8C0r+N7yzqstzl3yf0tgzER5RaN3rBaBiGoSFwcucyaRnoLa07Dl9LFI?=
 =?us-ascii?Q?H4S19y7HdpfYJjhqO3GX+SP8PTcWmaSE0qkoLWIVg3qfiJFuCbSqEc0h9wJt?=
 =?us-ascii?Q?hGQLtKJ157y/JoYxpxzHRboNqWn84v9Jr6zRA4yqQx2IuZXBEnDcDFyom/FO?=
 =?us-ascii?Q?kYpPpQtukre3p8i6rMreBHY0U1HIE5sa/b+2AeUNXDHrj2AMvuyxEGSdIAF8?=
 =?us-ascii?Q?IsvZV+Isjc3wJT9qrLr5kVZaeob2HvPVY8x1cgdAXpWYWsCq+eVYbQvj5wQY?=
 =?us-ascii?Q?SuLuxNT8T/xd4Mp2i8dsvMDZ6jzZW43NkpxCemC/F0qjmgoZViDLR3+SfSTt?=
 =?us-ascii?Q?Zkk1zhx9sbc4v1IbNglYH4EZQ1joj0LEi/8Z5+nPCCsrk0gErXUWeacpCiG0?=
 =?us-ascii?Q?RbGvAS13H5D6CXtrkMa2Tkr+gQ3rOxq1SgNSqclIonvJXmlZaVGFB60uD2kS?=
 =?us-ascii?Q?8ahPs1HhsHy3g6Dkbqdk6K0V3M9zPGO2BQ64oDGm2sO8lXw8lSCTRJo0HIMZ?=
 =?us-ascii?Q?94nGKMJCGV3DWh9mHU6JaTj1qmuPmg4a1+MA/sUloPyS875rAcj8UwV37K1X?=
 =?us-ascii?Q?60dEUnIBwxutdlBBaXdB6MDB8Axzk/xckNCejImeUyIkqeHMzN/d7H6s7cio?=
 =?us-ascii?Q?V+twrvdJUHZZkoihM0jbhGGhm3AzFVms3FYmALKjzgbjeemh2HJ1MHsPRhEY?=
 =?us-ascii?Q?7bOnAHeTn3zqmT6+MigABdfZsl944bLSJjP5qki8cZ0Gu6wEJJ/cWJnfTkko?=
 =?us-ascii?Q?bvTEzag0Ui8N5wind1lmoQdU?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1bcb4be-ee64-42a5-209e-08d930512de2
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2021 22:59:06.8594
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EUcTzwWlHb7wsG48O1W75Yb5a3hCz9hIFQeCBb3DfQj+HnSbi5OtkouSerQGnKNSUBfoKgSE624/60BpdVNK7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4571
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, June 15, 2021 11:07 PM
>=20
> On Tue, Jun 15, 2021 at 08:59:25AM +0000, Tian, Kevin wrote:
> > Hi, Jason,
> >
> > > From: Jason Gunthorpe
> > > Sent: Thursday, June 3, 2021 9:05 PM
> > >
> > > On Thu, Jun 03, 2021 at 06:39:30AM +0000, Tian, Kevin wrote:
> > > > > > Two helper functions are provided to support VFIO_ATTACH_IOASID=
:
> > > > > >
> > > > > > 	struct attach_info {
> > > > > > 		u32	ioasid;
> > > > > > 		// If valid, the PASID to be used physically
> > > > > > 		u32	pasid;
> > > > > > 	};
> > > > > > 	int ioasid_device_attach(struct ioasid_dev *dev,
> > > > > > 		struct attach_info info);
> > > > > > 	int ioasid_device_detach(struct ioasid_dev *dev, u32 ioasid);
> > > > >
> > > > > Honestly, I still prefer this to be highly explicit as this is wh=
ere
> > > > > all device driver authors get invovled:
> > > > >
> > > > > ioasid_pci_device_attach(struct pci_device *pdev, struct ioasid_d=
ev
> *dev,
> > > > > u32 ioasid);
> > > > > ioasid_pci_device_pasid_attach(struct pci_device *pdev, u32
> > > *physical_pasid,
> > > > > struct ioasid_dev *dev, u32 ioasid);
> > > >
> > > > Then better naming it as pci_device_attach_ioasid since the 1st
> parameter
> > > > is struct pci_device?
> > >
> > > No, the leading tag indicates the API's primary subystem, in this cas=
e
> > > it is iommu (and if you prefer list the iommu related arguments first=
)
> > >
> >
> > I have a question on this suggestion when working on v2.
> >
> > Within IOMMU fd it uses only the generic struct device pointer, which
> > is already saved in struct ioasid_dev at device bind time:
> >
> > 	struct ioasid_dev *ioasid_register_device(struct ioasid_ctx *ctx,
> > 		struct device *device, u64 device_label);
> >
> > What does this additional struct pci_device bring when it's specified i=
n
> > the attach call? If we save it in attach_data, at which point will it b=
e
> > used or checked?
>=20
> The above was for attaching to an ioasid not the register path

Yes, I know. and this is my question. When receiving a struct pci_device
at attach time, what should IOMMU fd do with it? Just verify whether=20
pci_device->device is same as ioasid_dev->device? if saving it to per-devic=
e
attach data under ioasid then when will it be further used?

I feel once ioasid_dev is returned in the register path, following operatio=
ns
(unregister, attach, detach) just uses ioasid_dev as the main object.

>=20
> You should call 'device_label' 'device_cookie' if it is a user
> provided u64
>=20

will do.

Thanks
Kevin