Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Jun 2021 20:02:15 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        "Alex Williamson (alex.williamson@redhat.com)" 
        <alex.williamson@redhat.com>, "Raj, Ashok" <ashok.raj@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Robin Murphy <robin.murphy@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        David Gibson <david@gibson.dropbear.id.au>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Jason Wang <jasowang@redhat.com>
Subject: Re: [RFC] /dev/ioasid uAPI proposal
Message-ID: <20210615230215.GA1002214@nvidia.com>
References: <MWHPR11MB1886422D4839B372C6AB245F8C239@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210528233649.GB3816344@nvidia.com>
 <MWHPR11MB188621A9D1181A414D5491198C3C9@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210603130519.GY1002214@nvidia.com>
 <MWHPR11MB1886BA2258AFD92D5249AC488C309@MWHPR11MB1886.namprd11.prod.outlook.com>
 <20210615150630.GS1002214@nvidia.com>
 <MWHPR11MB1886E9553A5054DF7D51F27D8C309@MWHPR11MB1886.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR11MB1886E9553A5054DF7D51F27D8C309@MWHPR11MB1886.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (206.223.160.26) by YTOPR0101CA0010.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:15::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15 via Frontend Transport; Tue, 15 Jun 2021 23:02:16 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1ltI4V-007G8F-5k; Tue, 15 Jun 2021 20:02:15 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9275e5f-92c4-4083-9ac0-08d930519f0a
X-MS-TrafficTypeDiagnostic: BL1PR12MB5333:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL1PR12MB5333799D1BC9BB4BE3BD016AC2309@BL1PR12MB5333.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: i9BWz4HQPvfpr7Vmm2izXnOEWZYzCdq3yRtoYbtr1FzvsnDgXlDNvBghBNEBsbyZPStfkD/Gschm5kNOduov8xHOfs8abg6wjrYJcPRH/6LvNev7QP+n4vbtMZCn1uttBn2XtKl5KFF1M7PUtaSqALlyY1YTwuVJciaRgt1fvlAHy41XMRnjhRafClN27V7hgjk2OndGuITO28Kb66TvJxIvIf+dxt2wOnT7kd+wmXEial100pGPEK/dR5Ik7cddDywTI4QCQzKhr3sqyjlQBoyDN7r7OwYnSbc4mYcpe0aYrogdDHZn6NvDxUijJTPDPxafB3WkwCqbzyPV5xT4ZuKEKY8OglnDtcDww/iUq7Vu5i9AyhLb1HVwJMMsO6z39/3tpFEnECP6oJItnpGAiMyzyKdhpc8VIRb7gZP4TN3G8W9l9VyjYILrA14zXvh8WK7Xie//BcQ496ZScDMJLVLis6n/cWMXCj/aVf9IK0M3Aq+YLV13/i6jEhyAm3hBJuB+xjyD49E2tLcOFxtQ1/zlTt2HxHMWlKw1Aw3RDAviUSfSG3BmfIhZ6XFFQyudIsrteghjo6G11SnTBaTGRRPWk2AJ+auCY/5ck7mwT68=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(66476007)(66946007)(66556008)(4326008)(426003)(2616005)(8676002)(478600001)(8936002)(26005)(186003)(83380400001)(54906003)(316002)(2906002)(36756003)(9746002)(9786002)(7416002)(33656002)(5660300002)(6916009)(1076003)(86362001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qnJ4IA28wRprh263x2VeVM6MgPxgqjelIriK/NDJrlPz7l4UWrpDsP2Q24Ch?=
 =?us-ascii?Q?RrnqhEr5j18ONeUQ+urqduuvJmiP9GDHeXm3sv6bWxIXGTLartHUGFLP5Fpt?=
 =?us-ascii?Q?luJj0gmSVztm0zG99wYUFigP5ck95FghYqHkr+j598H2yR08zubXLCBhcwMM?=
 =?us-ascii?Q?YqDKf+NTYhNqOgT4CkrpyS0fIrg5nJ2ghsEDbthq1T8Ue9G++my2tBfIGlxJ?=
 =?us-ascii?Q?gYgxDXr6aSNELwo90hYxGYhWF6pav8z2/Bk5nUVRKZfEzApDRBft3wiXL9+9?=
 =?us-ascii?Q?Kn1V/jPhAiLasTP+hrU2pCaBGODfwRw6ukjSIWzDeSHRKyUAHm15IwykO4WP?=
 =?us-ascii?Q?ZTxv5ClSh+6qh9sf1HL5HLjyTgtWEGQmflQLc7A+xD32yVBUJOBWK6CDR0x7?=
 =?us-ascii?Q?H9IqnME7HrGK6WETJ7vaXQDnaNj9zYAcvIj4Yo62auT6AolxHjr9LRMSC9ll?=
 =?us-ascii?Q?1qmw8jHAn75+PNpP6aoy8iy4n+wP9s8nJR1HuvbJpF/YXRVc+Pc1SN7EDnfn?=
 =?us-ascii?Q?QRoqaEwHI/1NyeVt/J0eSm2Pj7WPvKqsqi6CHcxx+lAfLWYdJFk8wefHQUkX?=
 =?us-ascii?Q?wgdYwX2jK6N3B1la937oOAD8cHF5oObVvI7fEW2RqKKfagzApefw8G52/Kok?=
 =?us-ascii?Q?j41ZV5aI35vqWJjUc7sajt8oqDTaPySs7vgBhsOyz9lWb7Iht0YTOiCvB18s?=
 =?us-ascii?Q?YLzmxBgKTVyVT6n+c7YlWylYGV5uYCnqTTfiYnDBcsOazQ/3qnKdv2zGlPFZ?=
 =?us-ascii?Q?jTPh+sIlDwZQjVu7+WzAwVO0E0XjmpIB39YDGped4LkLZhFNceKw4yHBpWf5?=
 =?us-ascii?Q?QABVOKcresYCbCgKXxgiKXl4r87fWwCvTTZ+Dj0sK+540UFXUSJePFvfSWEY?=
 =?us-ascii?Q?HMxTe4cBlCs1ikKB4qfmlCgkFiszgbvKCspo0w5T8btgZK8TnmFywyYVnWdz?=
 =?us-ascii?Q?hG9nvLQBM7zP4la4TaAnzlUvNw4jvnSVXY8u5+OO/ZqbPN4BfoQN0b2oZKfD?=
 =?us-ascii?Q?WZ30iDKaaudYxQzncMIAh/lgh5A34P/Xn242KUV9/4JXKU3h7j6XTjVXagft?=
 =?us-ascii?Q?uOo1Uffgm8ssQXZ46tlAhq68yD3eDdzeyGg4C50tT8UNTKDPvAz1/DEAR35S?=
 =?us-ascii?Q?mfcKI8YRoo56k2LdwJEEaljSn1DunP1rvbFNsc4M0t8AFp5H7HB75rCCiU1e?=
 =?us-ascii?Q?NbWxGtSXBo54IQj9WyFbZ0OugLgB+dvcErMbDifnoSoxKqUZymPBWm4612rH?=
 =?us-ascii?Q?Zemgrgl/XxR0fCKRJ4EcwjRbDV6EkanMpprggK+z+9QAII2IQgpbA0io6DHA?=
 =?us-ascii?Q?2GpIOFUvsbLqR84YvIzI37Ir?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9275e5f-92c4-4083-9ac0-08d930519f0a
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 23:02:16.9168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: stq5gZO4eBv14vCbTvWaSJFHCSMBcpkuOhTJr1luiWmwnBbFlQ5Z0iifGK3KkjqZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5333
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 15, 2021 at 10:59:06PM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Tuesday, June 15, 2021 11:07 PM
> > 
> > On Tue, Jun 15, 2021 at 08:59:25AM +0000, Tian, Kevin wrote:
> > > Hi, Jason,
> > >
> > > > From: Jason Gunthorpe
> > > > Sent: Thursday, June 3, 2021 9:05 PM
> > > >
> > > > On Thu, Jun 03, 2021 at 06:39:30AM +0000, Tian, Kevin wrote:
> > > > > > > Two helper functions are provided to support VFIO_ATTACH_IOASID:
> > > > > > >
> > > > > > > 	struct attach_info {
> > > > > > > 		u32	ioasid;
> > > > > > > 		// If valid, the PASID to be used physically
> > > > > > > 		u32	pasid;
> > > > > > > 	};
> > > > > > > 	int ioasid_device_attach(struct ioasid_dev *dev,
> > > > > > > 		struct attach_info info);
> > > > > > > 	int ioasid_device_detach(struct ioasid_dev *dev, u32 ioasid);
> > > > > >
> > > > > > Honestly, I still prefer this to be highly explicit as this is where
> > > > > > all device driver authors get invovled:
> > > > > >
> > > > > > ioasid_pci_device_attach(struct pci_device *pdev, struct ioasid_dev
> > *dev,
> > > > > > u32 ioasid);
> > > > > > ioasid_pci_device_pasid_attach(struct pci_device *pdev, u32
> > > > *physical_pasid,
> > > > > > struct ioasid_dev *dev, u32 ioasid);
> > > > >
> > > > > Then better naming it as pci_device_attach_ioasid since the 1st
> > parameter
> > > > > is struct pci_device?
> > > >
> > > > No, the leading tag indicates the API's primary subystem, in this case
> > > > it is iommu (and if you prefer list the iommu related arguments first)
> > > >
> > >
> > > I have a question on this suggestion when working on v2.
> > >
> > > Within IOMMU fd it uses only the generic struct device pointer, which
> > > is already saved in struct ioasid_dev at device bind time:
> > >
> > > 	struct ioasid_dev *ioasid_register_device(struct ioasid_ctx *ctx,
> > > 		struct device *device, u64 device_label);
> > >
> > > What does this additional struct pci_device bring when it's specified in
> > > the attach call? If we save it in attach_data, at which point will it be
> > > used or checked?
> > 
> > The above was for attaching to an ioasid not the register path
> 
> Yes, I know. and this is my question. When receiving a struct pci_device
> at attach time, what should IOMMU fd do with it? Just verify whether 
> pci_device->device is same as ioasid_dev->device? if saving it to per-device
> attach data under ioasid then when will it be further used?
> 
> I feel once ioasid_dev is returned in the register path, following operations
> (unregister, attach, detach) just uses ioasid_dev as the main object.

The point of having the pci_device specific API was to convey bus
specific information during the attachment to the IOASID.

The registration of the device to the iommu_fd doesn't need bus
specific information, AFIAK? So just use a normal struct device
pointer

Jason