Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Jun 2021 01:24:43 +0200
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Yangbo Lu <yangbo.lu@nxp.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev,
        Richard Cochran <richardcochran@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Matthieu Baerts <matthieu.baerts@tessares.net>,
        Shuah Khan <shuah@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, Rui Sousa <rui.sousa@nxp.com>,
        Sebastien Laveze <sebastien.laveze@nxp.com>
Subject: Re: [net-next, v3, 05/10] ethtool: add a new command for getting PHC
 virtual clocks
Message-ID: <20210615232443.itunrkhaiy7h5gty@lion.mk-sys.cz>
References: <20210615094517.48752-1-yangbo.lu@nxp.com>
 <20210615094517.48752-6-yangbo.lu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210615094517.48752-6-yangbo.lu@nxp.com>
Precedence: bulk

On Tue, Jun 15, 2021 at 05:45:12PM +0800, Yangbo Lu wrote:
> Add an interface for getting PHC (PTP Hardware Clock)
> virtual clocks, which are based on PHC physical clock
> providing hardware timestamp to network packets.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> Changes for v3:
> 	- Added this patch.
> ---
>  include/linux/ethtool.h              |  2 +
>  include/uapi/linux/ethtool.h         | 14 +++++
>  include/uapi/linux/ethtool_netlink.h | 15 +++++
>  net/ethtool/Makefile                 |  2 +-
>  net/ethtool/common.c                 | 23 ++++++++
>  net/ethtool/common.h                 |  2 +
>  net/ethtool/ioctl.c                  | 27 +++++++++
>  net/ethtool/netlink.c                | 10 ++++
>  net/ethtool/netlink.h                |  2 +
>  net/ethtool/phc_vclocks.c            | 86 ++++++++++++++++++++++++++++
>  10 files changed, 182 insertions(+), 1 deletion(-)
>  create mode 100644 net/ethtool/phc_vclocks.c

When updating the ethtool netlink API, please update also its
documentation in Documentation/networking/ethtool-netlink.rst

Michal