Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4155798pxj; Tue, 15 Jun 2021 17:01:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTPfdQF6RC3zy+BWyEw/A7STk8NuH0xM0BmOKabmE6NWOcTchhoblaoALr3o7hZhl+dP79 X-Received: by 2002:a17:907:a92:: with SMTP id by18mr940253ejc.350.1623801711293; Tue, 15 Jun 2021 17:01:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623801711; cv=none; d=google.com; s=arc-20160816; b=k0pcDPZsfo+gihYEudDkhiTOjt2j0E+Y21LRBi1iKrmrBqzKXdCDVNMuivCTwQZeZc BLdzvr4ICCVV7s7ZQxJyX2MLxIN6A34bMZIFQtM3FuXKrwNzcseZjL4A8Zz48OrvYcpj a1ss2cqZjW3ZvdwYrV+QLGGhjMAqFrt1OjXFW0Enp0wAbiGzR8cNV1hlgSeN+GIjUA93 PSQeUjPDfI2MsM8emGjQgGQZozi2mUi/CUS7Uuu2d8urvo70cH2vV4DukdIm1xjjloSU 3s63BUo4TuG3mZ45I3Ex6r4O44xgPnlBtTqhLclILI5UzMuTYVUMToStiGmnDbo2j4Yz w8YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Cavx6x3nhYXx5BnoO8glUCwT6RHhCwAb/VYzJ1vZ0Uo=; b=xpemF75JeAntnQOjiuwcbiU1hNAuWx6b/QpD5zuS3kELzgvdOJsOBVmNMEweyTlCug Y6Lt82f0+jCo3qz9J/iNvSDoJdLy8j34AcSJqTxuIVpGyR6rVxqlHRv/J5p1hrTZ5wc0 RY6D65UE4I6YBV0RjZRllARSM1QdaVU1cghb2B4Z6hcRX/agBqnAZVToppTgj5jQCGny qc7Ho66TohU50rGQw8FT6MfpgTmGrev1nI3x2StdzTVmHySwoIPUu4Yhp5By4z/g3uyv b6T2u3D27yVuKjnkYDsvIOzTBaTQLg6uaSdbpYnbDuwfJ8jmjKHZtSRLZBrQJ3h0q1Sx r5pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=Pab3Zzxh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si551850ejj.448.2021.06.15.17.01.28; Tue, 15 Jun 2021 17:01:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=Pab3Zzxh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231499AbhFPACk (ORCPT + 99 others); Tue, 15 Jun 2021 20:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhFPACk (ORCPT ); Tue, 15 Jun 2021 20:02:40 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C96C061574 for ; Tue, 15 Jun 2021 17:00:35 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id l7-20020a05600c1d07b02901b0e2ebd6deso595776wms.1 for ; Tue, 15 Jun 2021 17:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Cavx6x3nhYXx5BnoO8glUCwT6RHhCwAb/VYzJ1vZ0Uo=; b=Pab3Zzxhu/tOKYzmcCnj0QqXTXH6fu4+7hf+f+cxFUFlbtNZTAVDuNr7sXGYalOAZH Aiac7+ZJjlISiIVcD7suOALI1LEMr3f2RhAtPJ2p7XlUfaAddPC93sjUNbMx4ckq3y0t HSVWKOYqeCxPyZbkf4idv1UsuhbpxGsSGMCmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cavx6x3nhYXx5BnoO8glUCwT6RHhCwAb/VYzJ1vZ0Uo=; b=PxhyJGQZYP5CqgHQobqWaDLTAJSS8E3bpAslKjr5fBCmEvmygGP5TsvElKXLjKLzMM JnWwJ5s2vjJqqQBYtBr6O/NbHb2SnxF9M5VENUzu6+sg9ZSwh5jcDqnefbJ0AivSZiMp 7TkWNrAWbrxMXFcLSOr0rUyTkXlRUgmUi9S6zhrb3xqk/CUJhBQFmvblFi7RJE5g7VgJ 3Cxtgzvre8Q7CKQAr9GaEf81pp1EpTkmNaxozRbpwh2gn0okyTL0zhVZblgFX8Ch3lxR 13qrqfkaHIQ4gPYGKPdVpN7djEb5X3sQbMYaIKnWeBCm6Vne3afubPepXb9K4zmKhcdJ reBQ== X-Gm-Message-State: AOAM5332mRVqzYNkksfEwmeq1Dng4dsu1rIWNkQbdQjZ1EdaNlIuMoaw yUdFZlMIKunJJR0meTaah6ZwLA== X-Received: by 2002:a05:600c:2284:: with SMTP id 4mr1930697wmf.146.1623801633607; Tue, 15 Jun 2021 17:00:33 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:db96]) by smtp.gmail.com with ESMTPSA id g10sm363204wrq.12.2021.06.15.17.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 17:00:33 -0700 (PDT) Date: Wed, 16 Jun 2021 01:00:32 +0100 From: Chris Down To: Andy Shevchenko Cc: Linux Kernel Mailing List , Petr Mladek , Jessica Yu , Sergey Senozhatsky , John Ogness , Steven Rostedt , Greg Kroah-Hartman , Johannes Weiner , Kees Cook , Andy Shevchenko , Rasmus Villemoes , kernel-team@fb.com Subject: Re: [PATCH v7 1/5] string_helpers: Escape double quotes in escape_special Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1 (4b100969) (2021-06-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: >> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm > >checked the uses Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak. Agreed on the others, though, hopefully they can be massaged in :-)