Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tyIwjpMfYdw8fli73qKOYRqWPzWgr3hPeA+KWE0GVU1kIBGaKM4VDw7kEb5QbUeF3Pntz0LtPw
 1B4DYobh7hHw==
IronPort-SDR: IUW+IbsdJrn5LO+okM2ePmFUC8DyNuW2n//StC1Zwjxyk42X2Bkrgx2Zuy829uF4II9aJ4WLTC
 6l0LFW3sV1/g==
From:   Kai Huang <kai.huang@intel.com>
To:     linux-sgx@vger.kernel.org, x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, bp@alien8.de, seanjc@google.com,
        jarkko@kernel.org, dave.hansen@intel.com, tglx@linutronix.de,
        mingo@redhat.com, Yang Zhong <yang.zhong@intel.com>,
        Kai Huang <kai.huang@intel.com>
Subject: [PATCH v2] x86/sgx: Add missing xa_destroy() when virtual EPC is destroyed
Date:   Wed, 16 Jun 2021 12:36:34 +1200
Message-Id: <20210616003634.320206-1-kai.huang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

xa_destroy() needs to be called to destroy virtual EPC's page array
before calling kfree() to free the virtual EPC.  Currently it is not
called.  Add the missing xa_destroy() to fix.

Fixes: 540745ddbc70 ("x86/sgx: Introduce virtual EPC for use by KVM guests")
Tested-by: Yang Zhong <yang.zhong@intel.com>
Acked-by: Dave Hansen <dave.hansen@intel.com>
Signed-off-by: Kai Huang <kai.huang@intel.com>
---
v1->v2:

 - Fixed typo in commit msg
 - Added Dave's Acked-by
---
 arch/x86/kernel/cpu/sgx/virt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
index 6ad165a5c0cc..64511c4a5200 100644
--- a/arch/x86/kernel/cpu/sgx/virt.c
+++ b/arch/x86/kernel/cpu/sgx/virt.c
@@ -212,6 +212,7 @@ static int sgx_vepc_release(struct inode *inode, struct file *file)
 		list_splice_tail(&secs_pages, &zombie_secs_pages);
 	mutex_unlock(&zombie_secs_pages_lock);
 
+	xa_destroy(&vepc->page_array);
 	kfree(vepc);
 
 	return 0;
-- 
2.31.1