Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7 1/5] string_helpers: Escape double quotes in
 escape_special
To:     Chris Down <chris@chrisdown.name>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Petr Mladek <pmladek@suse.com>, Jessica Yu <jeyu@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        John Ogness <john.ogness@linutronix.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Kees Cook <keescook@chromium.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>, kernel-team@fb.com
References: <cover.1623775748.git.chris@chrisdown.name>
 <af144c5b75e41ce417386253ba2694456bc04118.1623775748.git.chris@chrisdown.name>
 <CAHp75Vc-edpD5kz0EPsO7Q=zOPHWFckZzc17imO85dQy-PpOgg@mail.gmail.com>
 <YMk/IKA4okfYSh57@chrisdown.name>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <796701ff-18f9-a637-fca4-808ae36b336f@infradead.org>
Date:   Tue, 15 Jun 2021 19:05:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <YMk/IKA4okfYSh57@chrisdown.name>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/21 5:00 PM, Chris Down wrote:
> Andy Shevchenko writes:
>>> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm
>>
>> checked the uses
> 
> Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak.
> 
> Agreed on the others, though, hopefully they can be massaged in :-)

Ack, I don't see anything wrong with it either.