Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp86815pxj; Tue, 15 Jun 2021 20:51:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDjTSqElcppMes/ZKHKl2bxzvz7QsKsaYCuA524FK4NbaFjw3Z/JA7IfyOQ1Lm8Wy81mjI X-Received: by 2002:a17:907:20da:: with SMTP id qq26mr2948761ejb.42.1623815498325; Tue, 15 Jun 2021 20:51:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623815498; cv=none; d=google.com; s=arc-20160816; b=dC+CtenjXHOh+VIBojT0QaXQ4iywhSFuvxju6ssusyLdhaZVPyT5JXazjdCEOujlum v87XDWOTTMu7gGYAxSBCFqI0kkunMahJ5Jv4HJKHmrjep3qy0O9lBjvXbUiClTD0ibsz DjjpPevkCGR8f78OOZfwlBztGKsZE8DDrZf2DEdXyLTrgyyklWn+0edu4NhI41Z+3eIR r5/Hfv16tabjb7nqWwwgr4Es6GxlZIFwdCNX0vFd1Y2/a9udbyOpAT9j+QkRchE9jcc1 fzuWGhqqoLhyiTgd/03HE6cN2TlCVZxDuKjpwgLoqcwamaMZdnNnVtX1cRXPWoPa4WVn QS2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=eBZ9iTDWVc/GaeFMUtGU/2nLRGHZ0q9qDyCNFfvLlKM=; b=mswVDsP7tvoy7Br0qV/9xEot0aGaRfcVOTNUe05r0P+TLRog06ERwIGFdxFGqMUWnk tzmYt/9rtfqdCakdUW4IjHlS0pOO5DxJ5t+HJ6jltFAhsNYlLEXg4e47JQlwwuQC7PSp tWrxf/PsyTAAlg3wT4A79jAYUmFJZVy7YrlJrcoafgdnE4l//KytqDhZUqaqhTqfF8sD fyvx2RuWpTV7snrGwIjwjEeolW/77ZkD+r+5cA5NxnCwxdV6QhkpMwY1hLiLHDLctfDX EbpMsDvvvdtFLQIySV8p2V4sCzX7TgwbcmIOWcvEWg8tTzGrfziy5o8st8GITDAqYKZJ vXsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca12si844695edb.479.2021.06.15.20.51.16; Tue, 15 Jun 2021 20:51:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230027AbhFPDuV (ORCPT + 99 others); Tue, 15 Jun 2021 23:50:21 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:7287 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhFPDuV (ORCPT ); Tue, 15 Jun 2021 23:50:21 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G4WHP2vCNz1BN1k; Wed, 16 Jun 2021 11:43:13 +0800 (CST) Received: from dggemi762-chm.china.huawei.com (10.1.198.148) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 11:48:14 +0800 Received: from linux-lmwb.huawei.com (10.175.103.112) by dggemi762-chm.china.huawei.com (10.1.198.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 16 Jun 2021 11:48:13 +0800 From: Zou Wei To: , , , CC: , , Zou Wei Subject: [PATCH -next] mtd: rawnand: arasan: Fix missing clk_disable_unprepare() on error in anfc_probe() Date: Wed, 16 Jun 2021 12:06:44 +0800 Message-ID: <1623816404-66213-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggemi762-chm.china.huawei.com (10.1.198.148) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the missing clk_disable_unprepare() before return from anfc_probe() in the error handling case. Fixes: 61622f6791a1 ("mtd: rawnand: arasan: Use the right DMA mask") Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/mtd/nand/raw/arasan-nand-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c index 8317d97..9cbcc69 100644 --- a/drivers/mtd/nand/raw/arasan-nand-controller.c +++ b/drivers/mtd/nand/raw/arasan-nand-controller.c @@ -1452,7 +1452,7 @@ static int anfc_probe(struct platform_device *pdev) ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); if (ret) - return ret; + goto disable_bus_clk; ret = anfc_parse_cs(nfc); if (ret) -- 2.6.2