Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp103735pxj; Tue, 15 Jun 2021 21:18:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw50I2vF2uU7+itAFmT+jbca9b+wpE420CCRRMBtG+Me1AwaZM3ATTCtsgcdkwKN8efPUvW X-Received: by 2002:a17:907:9e1:: with SMTP id ce1mr3061196ejc.104.1623817117579; Tue, 15 Jun 2021 21:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623817117; cv=none; d=google.com; s=arc-20160816; b=OKifexVc2m32VY92CWCkJQjv/YRIHJJQyr7oSKxXndLDyH0p9MhPvE4uJ+AmJScROH HKvj94Bu0SmF36mnDQIZH09IH4KpCOoUa2oMmwUVH2/1nexRMGJTEeY4duy6x8iuEJcV PsJyWJusnQ07BBRrxNjE08gm9ZGES+V9S9acdZZhGtWMQSGItrYa/h+pg0Pz5wb7VmAV QOMDVx7XMLdYPBQo9pvjuwfJ2f84kNsJpWbaHP+tPOVPZ9f0yu80xbzf2B5evjxGg35G onWjEUPYC1PQAQQYqHPRKQe5YhAEgD8ijcoEyqIyd70lJOE1pcnuUnymFjKjzsI0Skus lZ4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FBmL5YaugDpb37XkNz3QPhL4HdFTy7pF9DkYAujNXh4=; b=DNHrVqSAKVxGBqwvvrsLdqzCTd4M6LHPCiaWNCc3WpIQmyzvEZbP697S0GuGWb/rFm feCXhN8h78tIz85YfHS4K58D+tGDnndlOQGQE5Cyeu0WFuAraRkIVnX+IXZl0rhIxvuL UfaSGETjoyDkdtUyyf7ZFF+K36A2V8hQBleNPh/9Msd2GEIFiUDTPEWptvK7GvXmuTC7 2xOAZ3TiyUox9XXHkffWVRS1j+2lDVmCjPyPQlGVr+4FJ6Y5nnw+wva4qnPTJU2E/VC+ erDIdlkG8sl2j0hLBzAO1cZRohpTGpOl/MCVaeBjTezyKasQ+kuCdt9mHztLbZNNMaQR hq7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k9ImWtIF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si811338edi.394.2021.06.15.21.18.12; Tue, 15 Jun 2021 21:18:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k9ImWtIF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229559AbhFPERU (ORCPT + 99 others); Wed, 16 Jun 2021 00:17:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:58922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhFPERT (ORCPT ); Wed, 16 Jun 2021 00:17:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3323B61246; Wed, 16 Jun 2021 04:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623816914; bh=FVUaYjKHc+AKLajKsB3EM4ycBOxBIGMjhYSj8aEsVbo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k9ImWtIF40K0ojCF0m4NObfYejwVh6r5dwuWdoJG5IQjq1V950RGEFDbO2ENwCF3I oMJdAkPdgQHGo1zQr8MQXJAplt/nEXbW1dN3TD3daYWGB0jnIoBQmBT6On+FFqG3QQ pvkzjmUPE+j9fqMI4DwPt0e4/R3hysKL6DAtAscDt8dSTHlDIZZjj4E77osHks3k20 n7gppevuHN5O4G0hj5TiWsAYRHAR0DXtuJnt5Ge4vHlSKxfNIBvE/qwpUfPFLnJ/wh FFZPN6ULiyGp8uCons5sPB8+4xoRswRDw4lAVbzyu3PyMjFAPtVxgxiDo5MEBrEc5v 5YW64Bo+hzEJQ== Date: Wed, 16 Jun 2021 09:45:10 +0530 From: Vinod Koul To: Sanjay R Mehta Cc: Sanjay R Mehta , gregkh@linuxfoundation.org, dan.j.williams@intel.com, Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com, Nehal-bakulchandra.Shah@amd.com, robh@kernel.org, mchehab+samsung@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v9 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA Message-ID: References: <1622654551-9204-1-git-send-email-Sanju.Mehta@amd.com> <1622654551-9204-2-git-send-email-Sanju.Mehta@amd.com> <94bba5dd-b755-81d0-de30-ce3cdaa3f241@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94bba5dd-b755-81d0-de30-ce3cdaa3f241@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-06-21, 16:50, Sanjay R Mehta wrote: > >> +static struct pt_device *pt_alloc_struct(struct device *dev) > >> +{ > >> + struct pt_device *pt; > >> + > >> + pt = devm_kzalloc(dev, sizeof(*pt), GFP_KERNEL); > >> + > >> + if (!pt) > >> + return NULL; > >> + pt->dev = dev; > >> + pt->ord = atomic_inc_return(&pt_ordinal); > > > > What is the use of this number? > > > > There are eight similar instances of this DMA engine on AMD SOC. > It is to differentiate each of these instances. Are they individual device objects? -- ~Vinod