Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp125952pxj; Tue, 15 Jun 2021 21:55:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiL1U2JzE8pnrcUroFGKcPMnLqC6/xrdp71c8O/z3nj3ARSc3biYuNwyJB0t1VbyNnUTAW X-Received: by 2002:a17:906:a854:: with SMTP id dx20mr3333375ejb.128.1623819342291; Tue, 15 Jun 2021 21:55:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623819342; cv=none; d=google.com; s=arc-20160816; b=qId2DRjgIRHBVh+Xu2Ak+12kVl6LeOxYwcNMR5H7QNxpdOOYS3pOpCzBAzjjE8rXBU 6qTcQSYbKxKQOzrX4AlaLnw1XEh2PdghbpJaOELZegJHgv3Jy2anBpwcCymVTrDDwnT7 q9ZqFgf514XNfS1lWxGNN516JrR0DsbqOmg9xpMvrTSSsvrOQmIvlkaiQo5QVovWL2su Zsn7GCfelSzu6Sq8otD+ptJ7QRI8/0Tn3gayDU8tClHKfo1B7+krxBFeaR79Ipr7WvEL 9GbEReIc45OKsfeRXdy8wMrZd19K6FSCrv/epjWxz1FLhn2QqZa+n+n0pZiNuA25uYch gfTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9Xvl3Q2BcDnn3sLPuJT0gF3XCMgyvBysAyx7WRFcD6k=; b=a/JMItaj+eja6rgjUGtvtrsS/BxUqTTnAUcIXQZHSHevVkzPshUmMBawsf/bfqAy/+ 4q/+HbdxL2zt3YH0FlqBxsVJE1oQrORbNgeoMRwfXKxYMaTeHyTnzXfU4yPAoltNMmxp u4sB4yqLlxmWq4tFu2tfrUyS3mkKBWUWae8p+3Xw3TQfnNaVcpaXUKDEkNMQm7y5+/vw cwDKt/rMnzvtYI75N3vwqrnOBVQqjo25/2//N8a4FUyQfhxoc1W5hUHqxX3BnXMjvew3 Ilz3LCsSx1iSSWZ5aG5U+kadJFrZBThZ4LHfkdW5qLLs9ODiEuTa2Hv6tUToNAwCERMA FIOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hoy+nfIW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si1008335edc.576.2021.06.15.21.55.17; Tue, 15 Jun 2021 21:55:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hoy+nfIW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbhFPE4M (ORCPT + 99 others); Wed, 16 Jun 2021 00:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbhFPE4L (ORCPT ); Wed, 16 Jun 2021 00:56:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAAEC061574; Tue, 15 Jun 2021 21:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9Xvl3Q2BcDnn3sLPuJT0gF3XCMgyvBysAyx7WRFcD6k=; b=hoy+nfIWENzx8GAUiPRCr2RsfB zNT0KOgXy30afI0OD19/gwlKp+TPc+6ca1QNb0ddVkGQT/EqZDP/twuipJwBJ/lXfUUtIsqTFc6Jy 5I3ZoCCVVBO3qOHC731JeUKWn7LdArOx+BuUqMT0xZ4hbA494l1u/uX0hrPd5j6jXlOk86bbuMdsC 34SqtVR0QDr+T71XGVaWknHNeas7VKxTKSmzIagsrOaf/nk2Ch6a8RaGanlYW8Bex86zTKUe8qA0P iO4ye84sy7/5K2orTww85wALeFmyZF1HoL/B81bwqxKPDFmMKjjjEIFLiPAI8CadPavTmaSUaXB+Z gDB2ccvg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltNYM-007bdJ-Sv; Wed, 16 Jun 2021 04:53:39 +0000 Date: Wed, 16 Jun 2021 05:53:26 +0100 From: Christoph Hellwig To: edwardh Cc: axboe@kernel.dk, neilb@suse.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, s3t@synology.com, bingjingc@synology.com, cccheng@synology.com, Wade Liang Subject: Re: [PATCH v3] block: fix trace completion for chained bio Message-ID: References: <20210616030810.4901-1-edwardh@synology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616030810.4901-1-edwardh@synology.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 16, 2021 at 11:08:10AM +0800, edwardh wrote: > @@ -1400,18 +1404,13 @@ void bio_endio(struct bio *bio) > if (bio->bi_end_io == bio_chain_endio) { > bio = __bio_chain_endio(bio); > goto again; > + } else { > + blk_throtl_bio_endio(bio); > + /* release cgroup info */ > + bio_uninit(bio); > + if (bio->bi_end_io) > + bio->bi_end_io(bio); No need for an else after a goto.